Backport #1001

Interpreter-wide deadlock when native close() is called on fd which is currently being IO#select()ed

Added by coderrr (coderrr .) over 3 years ago. Updated about 1 year ago.

[ruby-core:21264]
Status:Closed Start date:01/12/2009
Priority:Normal Due date:
Assignee:wyhaines (Kirk Haines) % Done:

100%
Category:-
Target version:-

Description

details and fix here:

http://coderrr.wordpress.com/2009/01/11/ruby-and-mysqlplus-select-deadlock/

Associated revisions

Revision 22299
Added by akr over 3 years ago

* eval.c (rb_thread_schedule): handle EBADF of select as well. [ruby-core:21264]

Revision 23577
Added by shyouhei almost 3 years ago

merge revision(s) 22299: * eval.c (rb_thread_schedule): handle EBADF of select as well. [ruby-core:21264]

Revision 24600
Added by wyhaines almost 3 years ago

Backport #1001; handle EBADF in select() to avoid Interpreter-wide deadlock when native close() is called on fd which is currently being IO#select()ed.

History

#1
Updated by coderrr (coderrr .) over 3 years ago

any comments on this?

#2
Updated by rogerdpack (Roger Pack) over 3 years ago

it might be nice to submit a patch which "fixes" this.

My question, however, is what is the right behavior when a bad socket is discovered?  I believe Python raises on the thread that passed it in [not just ignore it], which seems reasonable.

Regardless, looks like a bug to me.  Is it exhibited in 1.9?

Thoughts?

#3
Updated by ko1 (Koichi Sasada) over 3 years ago

  • Assignee set to akr (Akira Tanaka)
  • ruby -v set to 1.8

#4
Updated by akr (Akira Tanaka) over 3 years ago

  • Status changed from Open to Closed
Thank you for investigating the problem.

However the fix makes IO.select hang when the fd is closed.
I think it is not good behavior.

#5
Updated by shyouhei (Shyouhei Urabe) about 3 years ago

  • Status changed from Closed to Open
  • Assignee changed from akr (Akira Tanaka) to shyouhei (Shyouhei Urabe)

#6
Updated by shyouhei (Shyouhei Urabe) almost 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
Applied in changeset r23577.

#7
Updated by shyouhei (Shyouhei Urabe) almost 3 years ago

  • Status changed from Closed to Open
  • Assignee changed from shyouhei (Shyouhei Urabe) to wyhaines (Kirk Haines)

#8
Updated by wyhaines (Kirk Haines) almost 3 years ago

  • Status changed from Open to Closed
Applied in r24600.

Also available in: Atom PDF