Bug #1320

sdbm.c compiler warnings

Added by cfis (Charlie Savage) about 3 years ago. Updated about 1 year ago.

[ruby-core:23039]
Status:Closed Start date:03/28/2009
Priority:Low Due date:
Assignee:matz (Yukihiro Matsumoto) % Done:

100%
Category:ext
Target version:1.9.2
ruby -v:ruby 1.9.2dev (2009-03-28) [i386-mswin32_90]

Description

A couple of compiler warnings are still left in sdbm extension:

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/sdbm -nologo -MDd -Zi -RTC1 -W3 -wd4996 -Od  -Zm600 -DRUBY_EXTCONF_H=\"extconf.h\"   -I. -I./.. -I./../missing 
-IC:\Development\msvc\include -Fo_sdbm.obj -c -Tc../.././../ext/sdbm/_sdbm.c _sdbm.c

../.././../ext/sdbm/_sdbm.c(207) : warning C4133: 'function' : incompatible types - from '_stat64 *' to 'stat *'

../.././../ext/sdbm/_sdbm.c(214) : warning C4244: '=' : conversion from '__int64' to 'long', possible loss of data

Associated revisions

Revision 27730
Added by nobu (Nobuyoshi Nakada) about 2 years ago

* ext/sdbm/sdbm.h (DBM): large file support on win32. [ruby-core:23039] * ext/sdbm/depend: objects depend on sdbm.h.

History

#1
Updated by yugui (Yuki Sonoda) almost 3 years ago

  • Priority changed from Normal to Low
  • Target version changed from 1.9.1 to 1.9.2

#2
Updated by yugui (Yuki Sonoda) almost 3 years ago

  • Assignee set to matz (Yukihiro Matsumoto)

#3
Updated by usa (Usaku NAKAMURA) about 2 years ago

  • Status changed from Open to Closed
can't reproduce with VC9 and r27729.
maybe already fixed.

#4
Updated by nobu (Nobuyoshi Nakada) about 2 years ago

  • Status changed from Closed to Open
It needs -W3 option to reproduce.

#5
Updated by nobu (Nobuyoshi Nakada) about 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r27730.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

Also available in: Atom PDF