Bug #14039: MinGW - OpenSSL::TestSSL#test_max_version & #test_min_version, TestNetHTTPS#test_max_version

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.5.0dev (2017-10-22 trunk 60317) [x64-mingw32]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN

[MSP-Greg (Greg L)]

I was triggering constant Appveyor builds to keep up with the recent flurry of commits (thanks everyone). When the dust settled, I have the following three issues.

 79) Failure:
OpenSSL::TestSSL#test_max_version [ruby/test/openssl/test_ssl.rb:837]:
<0> expected to be != to
<0>.

 80) Failure:
TestNetHTTPS#test_max_version [ruby/test/net/http/test_https.rb:219]:
Expected /\ASSL_connect returned=1 errno=0 / to match "SSL_CTX_set_max_proto_version".

 81) Error:
OpenSSL::TestSSL#test_min_version:
OpenSSL::SSL::SSLError: SSL_CTX_set_min_proto_version
    build25_64/.ext/common/openssl/ssl.rb:176:in `set_minmax_proto_version'
    build25_64/.ext/common/openssl/ssl.rb:176:in `min_version='
    build25_64/.ext/common/openssl/ssl.rb:140:in `block in set_params'
    build25_64/.ext/common/openssl/ssl.rb:140:in `each'
    build25_64/.ext/common/openssl/ssl.rb:140:in `set_params'
    ruby/test/openssl/test_ssl.rb:821:in `test_min_version'

I worked on openssl/test_ssl.rb; I couldn't get the tests passing. But, #test_minmax_version passes, and it was added at the same time as #min_version= and #max_version= (by @rhenium (Kazuki Yamaguchi)).

The build is using OpenSSL 1.1.0f and compiling with gcc 7.2.0.

Thanks, Greg

[rhenium (Kazuki Yamaguchi)]

The one from net/http tests is fixed by r60380.

• Status changed from Open to Closed

Applied in changeset trunk|r60636.

---

openssl: pull test case from upstream commit 62af0446569a

The test case added by r60310 ("fix OpenSSL::SSL::SSLContext#min_version
doesn't work", 2017-10-21) does not pass with OpenSSL >= 1.1.0 or
LibreSSL >= 2.6.0. Check that the default 'min_version' value is
properly enforced by actually attempting a handshake rather than by
inspecting the SSL option flags. [ruby-core:83479] [Bug #14039]