Project

General

Profile

Actions

Bug #17372

closed

Actions Windows MinGW failures 2020-12-06

Added by MSP-Greg (Greg L) almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:101264]

Description

JFYI, I'm trying to sort out the recent failures in Windows mingw.

ruby-loco Actions builds (both mingw & mswin) are failing, same tests failing as mingw CI here.

ruby-loco AppVeyor build (only mingw) is passing.

Both ruby-loco mingw builds (Actions & AppVeyor) use the same scripts.

Can't repo the failures locally. Frustrated...

Updated by MSP-Greg (Greg L) almost 4 years ago

@Eregon (Benoit Daloze)
@hsbt (Hiroshi SHIBATA)

The cause of the failure in the MinGW CI is the setting of ENV['BUNDLER_VERSION'] by ruby/setup-ruby, and also the fact that the RubyGems test suite (maybe TestCase?) is not accounting for that ENV variable in its setup.

I removed the setting in both ruby-loco and the MinGW CI here, and all of them passed. As mentioned above, I couldn't repo this locally, and the ruby-loco build passed in AppVeyor. Neither had ENV['BUNDLER_VERSION'] set...

I may do a PR, as this should be guarded against regardless?

Updated by Eregon (Benoit Daloze) almost 4 years ago

Sorry about that. Yes, it would be useful to handle this better in RubyGems' test suite, either raise an error if it's set or make sure it's unset while running the tests.

Updated by MSP-Greg (Greg L) almost 4 years ago

@Eregon (Benoit Daloze)

Thanks. I checked MinGW in my ruby fork, so I haven't done PR. Will you add a release in setup-ruby? Not sure when RubyGems would be patched, probably better if the patch comes from RubyGems? I did open a (passing) PR there for TestCase.

Actions #4

Updated by k0kubun (Takashi Kokubun) almost 4 years ago

  • Status changed from Open to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0