Bug #2357

make install fails due recent Tempfile modifications

Added by luislavena (Luis Lavena) over 2 years ago. Updated about 1 year ago.

[ruby-core:26681]
Status:Closed Start date:11/11/2009
Priority:Normal Due date:
Assignee:- % Done:

100%
Category:core
Target version:2.0.0
ruby -v:ruby 1.8.6 (2009-08-04 patchlevel 383) [i386-mingw32]

Description

Hello,

Changes introduced in revision 25720 broke the install process of trunk:

<pre><code>
./miniruby.exe -I../ruby_1_9/lib -I.ext/common -I./- -r../ruby_1_9/ext/purelib.rb  ../ruby_1_9/tool/rbinstall.rb --make="make" --dest-dir="" --extout=".ext" --mflags="" --make-flags="" --data-mode=0644 --prog-mode=0755 --installed-list .installed.list --mantype="man"
installing binary commands:   C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/bin
installing base libraries:    C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/lib
installing arch files:        C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/lib/ruby/1.9.1/i386-mingw32
installing command scripts:   C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/bin
installing library scripts:   C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/lib/ruby/1.9.1
installing common headers:    C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/include/ruby-1.9.1
installing manpages:          C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby19_mingw/share/man/man1
C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby_1_9/lib/tempfile.rb:136:in `block in initialize': undefined method `delete' for nil:NilClass (NoMethodError)
        from C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby_1_9/lib/tmpdir.rb:155:in `create'
        from C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby_1_9/lib/tempfile.rb:134:in `initialize'
        from C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby_1_9/lib/tempfile.rb:298:in `new'
        from C:/Users/Luis/Projects/oss/oci/rubyinstaller/sandbox/ruby_1_9/lib/tempfile.rb:298:in `open'
        from ../ruby_1_9/tool/rbinstall.rb:490:in `block (2 levels) in <main>'
        from ../ruby_1_9/tool/rbinstall.rb:475:in `each'
        from ../ruby_1_9/tool/rbinstall.rb:475:in `block in <main>'
        from ../ruby_1_9/tool/rbinstall.rb:549:in `call'
        from ../ruby_1_9/tool/rbinstall.rb:549:in `block (2 levels) in <main>'
        from ../ruby_1_9/tool/rbinstall.rb:546:in `each'
        from ../ruby_1_9/tool/rbinstall.rb:546:in `block in <main>'
        from ../ruby_1_9/tool/rbinstall.rb:542:in `each'
        from ../ruby_1_9/tool/rbinstall.rb:542:in `<main>'
make: *** [do-install-nodoc] Error 1
</code></pre>

Subversion information:
<pre><code>
------------------------------------------------------------------------
r25720 | nobu | 2009-11-11 07:17:36 -0300 (mié, 11 nov 2009) | 4 lines

* lib/tempfile.rb (Tempfile#initialize): merge mode option.

* lib/tmpdir.rb (Dir::Tmpname#create): splat options.
</code></pre>

Reverting to previous revision works.

Associated revisions

Revision 25723
Added by nobu (Nobuyoshi Nakada) over 2 years ago

* lib/tempfile.rb (Tempfile#initialize): option hash may not be given. [ruby-core:26681]

History

#1
Updated by nobu (Nobuyoshi Nakada) over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r25723.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

Also available in: Atom PDF