Backport #2556

Should r24500 be backported to 1.8?

Added by brixen (Brian Ford) over 2 years ago. Updated 10 months ago.

[ruby-core:27401]
Status:Assigned Start date:01/05/2010
Priority:Normal Due date:
Assignee:shyouhei (Shyouhei Urabe) % Done:

100%
Category:lib
Target version:Ruby 1.8.7

Description

Should http://redmine.ruby-lang.org/repositories/diff/ruby-19?rev=24500 be backported to 1.8?

$ ruby -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.8.6 (2008-08-11 patchlevel 287) [universal-darwin9.0]
"2010-01-10"
$ ruby1.8.7 -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.8.7 (2009-12-24 patchlevel 248) [i686-darwin9.8.0]
"2010-01-10"
$ ruby1.9 -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.9.2dev (2009-12-16 trunk 26107) [i386-darwin9.8.0]
"2010-01-04"

Monday of the first week of 2010 is clearly not 1/10, so the change in r24500 would seem to be a bug fix. I searched for a ticket for the change made in r24500 but could not find one.

Thanks,
Brian

Associated revisions

Revision 32574
Added by knu (Akinori MUSHA) 10 months ago

Backport r24500; fixes #2556. * lib/date.rb (complete_frags): Monday must be suitable for %W's default day.

History

#1
Updated by naruse (Yui NARUSE) over 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to knu (Akinori MUSHA)

#2
Updated by knu (Akinori MUSHA) about 2 years ago

  • Assignee changed from knu (Akinori MUSHA) to tadf (tadayoshi funaba)
Can we backport this?

#3
Updated by tadf (tadayoshi funaba) almost 2 years ago

maybe ok.

#4
Updated by tadf (tadayoshi funaba) almost 2 years ago

  • Assignee changed from tadf (tadayoshi funaba) to knu (Akinori MUSHA)

#5
Updated by knu (Akinori MUSHA) 10 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r32574. Brian, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you. ---------- Backport r24500; fixes #2556. * lib/date.rb (complete_frags): Monday must be suitable for %W's default day.

[ruby-core:38136]#6
Updated by knu (Akinori MUSHA) 10 months ago

  • Status changed from Closed to Assigned
  • Assignee changed from knu (Akinori MUSHA) to shyouhei (Shyouhei Urabe)
Backport to 1.8.7 is up to you.

Also available in: Atom PDF