Backport #3118

backport r25230 and r25995 to fix segfault

Added by mkent (Matthew Kent) about 2 years ago. Updated about 1 year ago.

[ruby-core:29393]
Status:Assigned Start date:04/10/2010
Priority:High Due date:
Assignee:wyhaines (Kirk Haines) % Done:

0%

Category:-
Target version:-

Description

Spent some time tracking down a segfault introduced in newer versions of 1.8.6. 

mkent@el-test:~/git/matzruby (p306)$ ruby -v ~/open4_segfault.rb
ruby 1.8.6 (2010-02-05 patchlevel 399) [x86_64-linux]
1000 calls
/home/mkent/.gem/ruby/1.8/gems/open4-1.0.1/lib/open4.rb:52: [BUG] Segmentation fault
ruby 1.8.6 (2010-02-05) [x86_64-linux]

Aborted

After much testing it seems the changes introduced in 1.8.6 p306 are at fault as p305 and earlier don't exhibit the problem. 

As 1.8.7 p174 and up work fine I've identified the following changes that correct the issue:

http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25230
http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25995
also requires
http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=16015

after which the example I've enclosed can do 200,000 calls without issue.

open4_segfault.rb - simple segfault example (410 Bytes) mkent (Matthew Kent), 04/10/2010 02:45 am

History

Updated by wyhaines (Kirk Haines) about 2 years ago

On Fri, Apr 9, 2010 at 11:45 AM, Matthew Kent <redmine@ruby-lang.org> wrote:
> Backport #3118: backport r25230 and r25995 to fix segfault
> http://redmine.ruby-lang.org/issues/show/3118
>
> Author: Matthew Kent
> Status: Open, Priority: High
> Assigned to: Kirk Haines
>
> Spent some time tracking down a segfault introduced in newer versions of 1.8.6.
>
> mkent@el-test:~/git/matzruby (p306)$ ruby -v ~/open4_segfault.rb
> ruby 1.8.6 (2010-02-05 patchlevel 399) [x86_64-linux]
> 1000 calls
> /home/mkent/.gem/ruby/1.8/gems/open4-1.0.1/lib/open4.rb:52: [BUG] Segmentation fault
> ruby 1.8.6 (2010-02-05) [x86_64-linux]
>
> Aborted
>
> After much testing it seems the changes introduced in 1.8.6 p306 are at fault as p305 and earlier don't exhibit the problem.
>
> As 1.8.7 p174 and up work fine I've identified the following changes that correct the issue:
>
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25230
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25995
> also requires
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=16015
>
> after which the example I've enclosed can do 200,000 calls without issue.

Thank you.  I am looking at it now.


Kirk Haines

Updated by wyhaines (Kirk Haines) about 2 years ago

On Fri, Apr 9, 2010 at 11:45 AM, Matthew Kent <redmine@ruby-lang.org> wrote:
> Backport #3118: backport r25230 and r25995 to fix segfault
> http://redmine.ruby-lang.org/issues/show/3118
>
> Author: Matthew Kent
> Status: Open, Priority: High
> Assigned to: Kirk Haines
>
> Spent some time tracking down a segfault introduced in newer versions of 1.8.6.
>
> mkent@el-test:~/git/matzruby (p306)$ ruby -v ~/open4_segfault.rb
> ruby 1.8.6 (2010-02-05 patchlevel 399) [x86_64-linux]
> 1000 calls
> /home/mkent/.gem/ruby/1.8/gems/open4-1.0.1/lib/open4.rb:52: [BUG] Segmentation fault
> ruby 1.8.6 (2010-02-05) [x86_64-linux]
>
> Aborted
>
> After much testing it seems the changes introduced in 1.8.6 p306 are at fault as p305 and earlier don't exhibit the problem.
>
> As 1.8.7 p174 and up work fine I've identified the following changes that correct the issue:
>
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25230
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=25995
> also requires
> http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=16015
>
> after which the example I've enclosed can do 200,000 calls without issue.

Thank you.  I am looking at it now.


Kirk Haines

Updated by shyouhei (Shyouhei Urabe) over 1 year ago

  • Status changed from Open to Assigned

Also available in: Atom PDF