Feature #3939

Language of error message as English by default on Windows

Added by phasis68 (Heesob Park) over 1 year ago. Updated about 1 year ago.

[ruby-core:32765]
Status:Closed Start date:10/13/2010
Priority:Normal Due date:
Assignee:usa (Usaku NAKAMURA) % Done:

100%
Category:core
Target version:2.0.0

Description

After r29450, the default system error message is English on Windows.

I wish the other modules using FormatMessage also be modified in order to get default English error message.

The remaining codes are dlc.c, thread_win32.c and win32ole.c.

Associated revisions

Revision 29478
Added by usa (Usaku NAKAMURA) over 1 year ago

* thread_win32.c (w32_error): get English message first, instead of system default. see [ruby-core:32765]. [experimental]

Revision 29507
Added by suke (Masaki Suketa) over 1 year ago

* ext/win32ole/win32ole.c (ole_hresult2msg): get English message first, instead of system default. [ruby-core:32765]

History

#1
Updated by usa (Usaku NAKAMURA) over 1 year ago

  • Category changed from core to ext
  • Status changed from Open to Assigned
  • Assignee set to suke (Masaki Suketa)
I've changed thread_win32.c now.

Suketa-san, if you want to follow these experimental changes, do it.
If not, reject this ticket.

#2
Updated by suke (Masaki Suketa) over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r29507.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

#3
Updated by suke (Masaki Suketa) over 1 year ago

  • Category changed from ext to core
  • Status changed from Closed to Assigned
  • Assignee changed from suke (Masaki Suketa) to usa (Usaku NAKAMURA)
I've changed win32ole.c now.
Nakamura-san, how about dln.c?

#4
Updated by usa (Usaku NAKAMURA) over 1 year ago

  • Status changed from Assigned to Closed
r29514 (by nobu).

Also available in: Atom PDF