Bug #454
URI does not follow the last rfc about uri syntax
| Status: | Rejected | Start date: | 08/19/2008 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  akira (akira yamada) |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| ruby -v: | - |
Description
According to the last rcf about uri syntax (http://www.ietf.org/rfc/rfc3986.txt), i have found at least two "bugs" in the uri library.
The "#" character is a delimiter and shouldn't be escaped. In the current implementation, it is, so the resulting escaped uri is no more the good one.
Example :
>> URI.escape('http://www.example.com/the page.html#fragment')
"http://www.example.com/the%20page.html%23fragment"
As a quick patch, the "#" character must be added to the URI::REGEXP::RESERVED regexp.
In the same way, URI::REGEXP::UNRESERVED specify characters that are not marked as unreserved by the rfc.
URI : UNRESERVED = "-_.!~*'()#{ALNUM}"
RFC : unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~"
History
Updated by jonaswitt (Jonas Witt) over 3 years ago
- File 454.patch added
lib/uri/common.rb currently references RFCs 2732 and 2396. RFC 3986, as linked to by the original poster, obsoletes both RFCs.
The attached patch adjusts the definitions of UNRESERVED and RESERVED to comply with RFC 3986, thereby fixing the "#" issue, among others:
> URI.escape('http://www.example.com/the page.html#fragment')
=> "http://www.example.com/the%20page.html#fragment"
This bug is filed against Ruby 1.8, but it's the same on the 1.9.1 branch and the same patch applies.
Updated by shyouhei (Shyouhei Urabe) over 3 years ago
- Assignee set to akira (akira yamada)
- ruby -v set to -
Updated by akira (akira yamada) over 3 years ago
- Status changed from Open to Rejected
URI.escape does not parse the argument string as an URI. The method only replace all UNSAFE chars in the string.