Bug #514

OpenSSL::OCSP::Response's to_der always returns an empty string

Added by squanderingtime (Chris Chandler) over 3 years ago. Updated about 1 year ago.

[ruby-core:18411]
Status:Closed Start date:08/28/2008
Priority:Normal Due date:
Assignee:gotoyuzo (GOTOU Yuuzou) % Done:

100%
Category:-
Target version:-
ruby -v:

Description

The OCSP response object always seems to produce an empty string when to_der is called.  The correct response should be a properly encoded DER response similar to the behavior of the other OpenSSL objects that implement to_der.

The problem appears to be on the call to i2d_OCSP_RESPONSE on line 382 (taken from SVN) in ossl_ocsp.c.  Instead of passing NULL as the second argument, it should be &p.  I have made the change locally and confirmed the output contains what appears to be the correctly formatted DER string.  I have also attached the recommended patch.  This bug is also present in the latest 1.9 build.

ruby-changes.patch (462 Bytes) squanderingtime (Chris Chandler), 08/28/2008 03:15 pm

Associated revisions

Revision 25019
Added by marcandre (Marc-Andre Lafortune) over 2 years ago

* ossl_ocsp.c (ossl_ocspres_to_der): Bug fix in Response#to_def. Patch by Chris Chandler [ruby-core:18411]

History

#1
Updated by shyouhei (Shyouhei Urabe) over 3 years ago

  • Assignee set to gotoyuzo (GOTOU Yuuzou)

#2
Updated by marcandre (Marc-Andre Lafortune) over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
Applied in changeset r25019.

Also available in: Atom PDF