Backport #5909

File.expand_path cases has no specs for some cases in Windows

Added by funny_falcon (Yura Sokolov) 4 months ago. Updated 4 months ago.

[ruby-core:42177]
Status:Closed Start date:01/19/2012
Priority:Normal Due date:
Assignee:naruse (Yui NARUSE) % Done:

100%
Category:-
Target version:-

Description

Following cases in file_expand_path has no tests. http://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/34215/entry/file.c#L2926 irb(main):014:0> Dir.pwd => "C:/Ruby193/bin" irb(main):015:0> File.expand_path('C:asdf', 'D:\home') => "C:/Ruby193/bin/asdf" irb(main):016:0> File.expand_path('C:asdf', 'C:\home') => "C:/home/asdf" http://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/34215/entry/file.c#L2969 irb(main):019:0> Dir.pwd => "C:/Ruby193/bin" irb(main):020:0> File.expand_path('\asdf') => "C:/asdf" irb(main):021:0> File.expand_path('\asdf', 'D:\home') => "D:/asdf" This specs are desirable for testing experimental version of File.expand_path , which uses Windows API (fenix by Luis Lavena)

Associated revisions

Revision 34503
Added by naruse (Yui NARUSE) 4 months ago

merge revision(s) 34338-34340: [Backport #5909] * test/ruby/test_file_exhaustive.rb (test_expand_path): add tests for absolute paths and drive letters. [ruby-core:42177] * test/ruby/test_file_exhaustive.rb (test_expand_path): ignore case of paths on DOSISH platforms. * test/ruby/test_file_exhaustive.rb (test_expand_path): fix commit miss, removed surplus downcase.

History

[ruby-core:42352]#1
Updated by funny_falcon (Yura Sokolov) 4 months ago

I see, issue is resolved by revisions 34338-34340. Could this tests be backported to ruby-1.9.3 ?

#2
Updated by kosaki (Motohiro KOSAKI) 4 months ago

  • Tracker changed from RubySpec to Backport
  • Project changed from ruby-trunk to Backport93
  • Category deleted (test)
  • Target version deleted (2.0.0)

[ruby-core:42372]#3
Updated by usa (Usaku NAKAMURA) 4 months ago

  • Status changed from Open to Assigned
  • Assignee set to naruse (Yui NARUSE)
naruse-san, do you think that we should backport tests?

[ruby-core:42373]#4
Updated by naruse (Yui NARUSE) 4 months ago

Usaku NAKAMURA wrote: > naruse-san, do you think that we should backport tests? yes, please

#5
Updated by naruse (Yui NARUSE) 4 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r34503. Yura, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you. ---------- merge revision(s) 34338-34340: [Backport #5909] * test/ruby/test_file_exhaustive.rb (test_expand_path): add tests for absolute paths and drive letters. [ruby-core:42177] * test/ruby/test_file_exhaustive.rb (test_expand_path): ignore case of paths on DOSISH platforms. * test/ruby/test_file_exhaustive.rb (test_expand_path): fix commit miss, removed surplus downcase.

Also available in: Atom PDF