Feature #5922
Migrate equal? to identical?
| Status: | Assigned | Start date: | 01/22/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  matz (Yukihiro Matsumoto) |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 2.0.0 |
Description
From Ruby docs: "the equal? method should never be overridden by subclasses: it is used to determine object identity (that is, a.equal?(b) iff a is the same object as b)."
I think it would make more sense to name such a method `#identical?`, since that is what it is doing --*comparing identity*. Over a sufficient period of time the current use of `#equal?` can be deprecated and possibly made better use of with a different definition. I realize this is not a minor change. This transition would probably be much like the one from #id to #object_id.
The reason I propose this, and why it is an issue for myself, is in of the design of assertion frameworks. For example, #assert_equal is a comparison of #==, not #equal?. We run into this naming conundrum and end up having to use assertion names that don't correspond well to the names of the underlying comparison. So that's the practical reason. But formally speaking, I think #identical? also better b/c it is more precise.
History
Updated by peter_v (Peter Vandenabeele) 4 months ago
+1
One could also be even more descriptive: "same_object?"
Updated by kernigh (George Koehler) 3 months ago
The name of #equal? is part of a pattern.
In Common Lisp:
(eq a b) ; most strict (eql a b) (equal a b) (equalp a b) ; least strict
In Ruby:
a == b # least strict a.eql? b a.equal? b # most strict
If #equal? loses its name, the pattern would be less obvious. Also, #eql? would lose its position between #== and #equal?.
If #equal? loses its name, I suggest that #eql? also loses its name.
- #equal? might become #identical? or #same_object?
- #eql? might become #hash_equal?
I guess that #eql? must not lose its name, because too much Ruby code already calls or defines #eql?.
Updated by mame (Yusuke Endoh) about 1 month ago
- Status changed from Open to Assigned
- Assignee set to matz (Yukihiro Matsumoto)