Backport #5984

Pathname binread test is testing read

Added by Eregon (Benoit Daloze) 4 months ago. Updated 4 months ago.

[ruby-core:42440]
Status:Closed Start date:02/09/2012
Priority:Normal Due date:
Assignee:- % Done:

100%
Category:-
Target version:-

Description

Hello, I noticed the 'binread' test in test/pathname/test_pathname.rb calls read instead of binread: diff --git a/test/pathname/test_pathname.rb b/test/pathname/test_pathname.rb index dcbcd49..1631403 100644 --- a/test/pathname/test_pathname.rb +++ b/test/pathname/test_pathname.rb @@ -710,7 +710,7 @@ class TestPathname < Test::Unit::TestCase def test_binread with_tmpchdir('rubytest-pathname') {|dir| open("a", "w") {|f| f.write "abc" } - assert_equal("abc", Pathname("a").read) + assert_equal("abc", Pathname("a").binread) } end

Associated revisions

Revision 34499
Added by naruse (Yui NARUSE) 4 months ago

* test/pathname/test_pathname.rb: not read but binread. patched by Benoit Daloze, [ruby-core:42440] [Bug #5984]

Revision 34500
Added by naruse (Yui NARUSE) 4 months ago

merge revision(s) 34499: * test/pathname/test_pathname.rb: not read but binread. patched by Benoit Daloze, [ruby-core:42440] [Bug #5984]

History

#1
Updated by naruse (Yui NARUSE) 4 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r34499. Benoit, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you. ---------- * test/pathname/test_pathname.rb: not read but binread. patched by Benoit Daloze, [ruby-core:42440] [Bug #5984]

#2
Updated by naruse (Yui NARUSE) 4 months ago

  • Tracker changed from Bug to Backport
  • Project changed from ruby-trunk to Backport93
  • Category deleted (lib)
  • Target version deleted (2.0.0)

Also available in: Atom PDF