Bug #653

`rake gem' emits a warning

Added by mame (Yusuke Endoh) over 3 years ago. Updated about 1 year ago.

[ruby-core:19351]
Status:Closed Start date:
Priority:High Due date:
Assignee:drbrain (Eric Hodel) % Done:

0%
Category:-
Target version:1.9.1 Release Candidate
ruby -v:

Description

Hi,

rake seems to call Gem.manage_gems which is deprecated at
lib/rake/gempackagetask.rb.


$ sow19 foo
(snip)
$ cd fo/
$ rake19
(in /tmp/foo)
<internal:0:Warning: Gem::manage_gems is deprecated and will be
removed on or after March 2009.
Hoe email value not set. aborting


Is it ok to merely remove the call?


Index: lib/rake/gempackagetask.rb
===================================================================
--- lib/rake/gempackagetask.rb	(revision 19808)
+++ lib/rake/gempackagetask.rb	(working copy)
@@ -9,12 +9,6 @@
 require 'rubygems/user_interaction'
 require 'rubygems/builder'

-begin
-  Gem.manage_gems
-rescue NoMethodError => ex
-  # Using rubygems prior to 0.6.1
-end
-
 module Rake

   # Create a package based upon a Gem spec.  Gem packages, as well as

-- 
Yusuke ENDOH <mame@tsg.ne.jp>

History

#1
Updated by drbrain (Eric Hodel) over 3 years ago

On Oct 16, 2008, at 10:09 AM, Jim Weirich wrote:
> On Oct 16, 2008, at 11:47 AM, Yusuke ENDOH wrote:
>> rake seems to call Gem.manage_gems which is deprecated at
>> lib/rake/gempackagetask.rb.
>>
>>
>> $ sow19 foo
>> (snip)
>> $ cd fo/
>> $ rake19
>> (in /tmp/foo)
>> <internal:0:Warning: Gem::manage_gems is deprecated and will be
>> removed on or after March 2009.
>> Hoe email value not set. aborting
>>
>>
>> Is it ok to merely remove the call?
>
>
> The gempackagetask should probably be allowed to continue to work  
> with older gems.  Can we put a version test around this?

RubyGems back to 0.8.8 will work if Gem.manage_gems is replaced with:

require 'rubygems/builder'

since all manage_gems did was require extra files like this one.

As of today, these are the versions of RubyGems that accessed the  
repository recently:

$ cut -d ' ' -f 13 gemmirror-access_log | occur | grep RubyGems
80668: "RubyGems/0.9.4"
69239: "RubyGems/0.9.5
22181: "RubyGems/0.9.2"
12268: "RubyGems/1.0.1
11679: "RubyGems/0.9.0"
11155: "RubyGems/1.0.0
  8813: "RubyGems/0.9.4.6
  3153: "RubyGems/0.8.11"
  1040: "RubyGems/0.8.10"
   438: "RubyGems/0.9.3"
   417: "RubyGems/0.9.1"
    67: "RubyGems/0.9.4.7
    26: "RubyGems/0.9.4.3"
    25: "RubyGems/0.9.5"
     5: "RubyGems/0.8.8"
     3: "RubyGems/0.8.99.2"
     2: "RubyGems/0.9.4.4"
     2: "RubyGems/0.9.0.8"
     1: "RubyGems/0.9.4
     1: "RubyGems/0.9.4.5"

So I think you're fine to remove the Gem.manage_gems call.

#2
Updated by ko1 (Koichi Sasada) over 3 years ago

  • Assignee set to drbrain (Eric Hodel)

#3
Updated by yugui (Yuki Sonoda) over 3 years ago

  • Priority changed from Low to High
  • Target version set to 1.9.1 Release Candidate

#4
Updated by yugui (Yuki Sonoda) over 3 years ago

Is this still reproduce? If not, close this issue.

#5
Updated by antares (Michael Klishin) over 3 years ago

It has been removed in both trunk and 1_9_1, I think this should be closed now.

#6
Updated by zenspider (Ryan Davis) over 3 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF