Bug #782

余分な外部シンボル

Added by tad (Tadashi Saito) over 3 years ago. Updated about 1 year ago.

[ruby-dev:37158]
Status:Closed Start date:11/24/2008
Priority:High Due date:
Assignee:matz (Yukihiro Matsumoto) % Done:

100%
Category:core
Target version:2.0.0
ruby -v:

Description

無意味に外部シンボルを増やさないでください。

Index: signal.c
===================================================================
--- signal.c    (revision 20337)
+++ signal.c    (working copy)
@@ -49,7 +49,6 @@

 #if defined(SIGSEGV) && defined(HAVE_SIGALTSTACK)
 #define USE_SIGALTSTACK
-int is_altstack_defined = 0;
 #endif

 static const struct signals {
@@ -424,6 +423,7 @@
 /* alternate stack for SIGSEGV */
 static void register_sigaltstack() {
     stack_t newSS, oldSS;
+    static int is_altstack_defined = 0;

     if(is_altstack_defined)
       return;

Associated revisions

Revision 20341
Added by matz (Yukihiro Matsumoto) over 3 years ago

* signal.c (register_sigaltstack): should not add external variable (with some cosmetic changes). [ruby-dev:37158]

History

#1
Updated by matz (Yukihiro Matsumoto) over 3 years ago

まつもと ゆきひろです

In message "Re: [ruby-dev:37158] [Bug #782] 余分な外部シンボル"
    on Mon, 24 Nov 2008 21:14:44 +0900, Tadashi Saito <redmine@ruby-lang.org> writes:
|
|Bug #782: 余分な外部シンボル
|http://redmine.ruby-lang.org/issues/show/782
|
|起票者: Tadashi Saito
|ステータス: Open, 優先度: High
|担当者: Yukihiro Matsumoto, カテゴリ: core, Target version: 1.9.x
|
|無意味に外部シンボルを増やさないでください。

staticがついていなかったのは私のミスですが、関数内部でstatic
にする意味はあんまりないんじゃないかと思うのですが、どうでしょ
う。

#2
Updated by matz (Yukihiro Matsumoto) over 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
Applied in changeset r20341.

Also available in: Atom PDF