Bug #825

Gem::Installer#generate_windows_script の引数の順番が他と一致しない

Added by okkez (okkez _) over 3 years ago. Updated about 1 year ago.

Status:Closed Start date:12/05/2008
Priority:Urgent Due date:
Assignee:drbrain (Eric Hodel) % Done:

0%
Category:lib
Target version:2.0.0
ruby -v:ruby 1.9.2dev (2009-11-09 trunk 25701) [x86_64-freebsd8.0]

Description

一つだけ引数の順番が異なるのは、混乱するので
Gem::Installer#generate_bin_script, Gem::Installer#generate_bin_symlink
と引数の順番を合わせました。

Index: lib/rubygems/installer.rb
===================================================================
--- lib/rubygems/installer.rb   (revision 20439)
+++ lib/rubygems/installer.rb   (working copy)
@@ -292,7 +292,7 @@
   ##
   # Creates windows .bat files for easy running of commands

-  def generate_windows_script(bindir, filename)
+  def generate_windows_script(filename, bindir)
     if Gem.win_platform? then
       script_name = filename + ".bat"
       script_path = File.join bindir, File.basename(script_name)
@@ -351,7 +351,7 @@

       say bin_script_path if Gem.configuration.really_verbose

-      generate_windows_script bindir, filename
+      generate_windows_script filename, bindir
     #else
     #  FileUtils.rm_f bin_script_path
     #  FileUtils.cp exec_path, bin_script_path,

History

#1
Updated by ko1 (Koichi Sasada) over 3 years ago

  • Assignee set to drbrain (Eric Hodel)

#2
Updated by yugui (Yuki Sonoda) over 3 years ago

  • Target version set to 2.0.0

#3
Updated by naruse (Yui NARUSE) over 2 years ago

  • Status changed from Open to Assigned
  • ruby -v set to ruby 1.9.2dev (2009-11-09 trunk 25701) [x86_64-freebsd8.0]
He says:
Gem::Installer#generate_windows_script has different argument's order from Gem::Installer#generate_bin_script, Gem::Installer#generate_bin_symlink.
So generate_windows_script should change its argument order.

#4
Updated by naruse (Yui NARUSE) over 2 years ago

  • Priority changed from Normal to Urgent

#5
Updated by drbrain (Eric Hodel) about 2 years ago

I have applied this patch to RubyGems trunk.

#6
Updated by drbrain (Eric Hodel) about 2 years ago

  • Status changed from Assigned to Closed
Appled r27441

Also available in: Atom PDF