Bug #883
Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref)
| Status: | Closed | Start date: | 12/15/2008 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  drbrain (Eric Hodel) |
% Done: | 100% |
|
| Category: | lib | |||
| Target version: | 1.9.2 | |||
| ruby -v: | ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux] |
Description
test failed with full path % ruby-trunk -v ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux] % ruby-trunk test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref Started . Finished in 0.153602 seconds. 1 tests, 210 assertions, 0 failures, 0 errors, 0 skips % ruby-trunk $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite /home/kazu/wc/ruby-lang/trunk/test/rdoc/test_rdoc_markup_to_html_crossref Started F Finished in 0.041989 seconds. 1) Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/home/kazu/wc/ruby-lang/trunk/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]: Expected "<p> <a href=\"../files/home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html\">/home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference.rb</a> </p> ", not "<p> /home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference.rb </p> ". 1 tests, 29 assertions, 1 failures, 0 errors, 0 skips %
Related issues
Associated revisions
* lib/rdoc/markup/to_html_crossref.rb: fix failure of the test.
[ruby-core:20564]
History
Updated by drbrain (Eric Hodel) over 3 years ago
- Category set to lib
- Assignee set to drbrain (Eric Hodel)
I cannot reproduce: $ ruby19 -v ruby 1.9.1 (2008-12-16 revision 20769) [i386-darwin9.5.0] $ ruby19 test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref Started . Finished in 0.078531 seconds. 1 tests, 210 assertions, 0 failures, 0 errors, 0 skips $ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite /Users/drbrain/Work/svn/ruby/trunk/test/rdoc/test_rdoc_markup_to_html_crossref Started . Finished in 0.081387 seconds. 1 tests, 210 assertions, 0 failures, 0 errors, 0 skips also, test-all passes for this test: $ make test-all TESTS=rdoc/test_rdoc_markup_to_html_crossref.rb ./miniruby -I./lib -I.ext/common -I./- -r./ext/purelib.rb ./runruby.rb --extout=.ext -- "./test/runner.rb" rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite ./test/runner Started . Finished in 0.086197 seconds. 1 tests, 210 assertions, 0 failures, 0 errors, 0 skips
Updated by znz (Kazuhiro NISHIYAMA) over 3 years ago
another failure example: % cd test % ruby-trunk ../test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite ../test/rdoc/test_rdoc_markup_to_html_crossref Started F Finished in 0.058379 seconds. 1) Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [../test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]: Expected "<p> <a href=\"../files/__/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html\">../test/rdoc/rdoc_markup_to_html_crossref_reference.rb</a> </p> ", not "<p> ../test/rdoc/rdoc_markup_to_html_crossref_reference.rb </p> ". 1 tests, 29 assertions, 1 failures, 0 errors, 0 skips %
Updated by candlerb (Brian Candler) over 3 years ago
> I cannot reproduce: I can reproduce here (Ubuntu Hardy) ruby-1.9.1-preview2$ ruby19 -v ruby 1.9.1 (2008-12-01 revision 20438) [i686-linux] ruby-1.9.1-preview2$ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb Loaded suite /v/build/ruby-1.9.1-preview2/test/rdoc/test_rdoc_markup_to_html_crossref Started F Finished in 0.046547 seconds. 1) Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/v/build/ruby-1.9.1-preview2/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]: Expected "<p> <a href=\"../files/v/build/ruby-1_9_1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html\">/v/build/ruby-1.9.1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference.rb</a> </p> ", not "<p> /v/build/ruby-1.9.1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference.rb </p> ". 1 tests, 29 assertions, 1 failures, 0 errors, 0 skips And here's on another Hardy machine running trunk from yesterday: ruby-svn$ ruby19 -v ruby 1.9.1 (2008-12-16 revision 20768) [i686-linux] brian@mappit:/v/downloads/ruby-svn$ ruby19 test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref Started . Finished in 0.528887 seconds. 1 tests, 210 assertions, 0 failures, 0 errors, 0 skips ruby-svn$ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb nil Loaded suite /v/downloads/ruby-svn/test/rdoc/test_rdoc_markup_to_html_crossref Started F Finished in 0.089370 seconds. 1) Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/v/downloads/ruby-svn/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]: Expected "<p> <a href=\"../files/v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html\">/v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference.rb</a> </p> ", not "<p> /v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference.rb </p> ". 1 tests, 29 assertions, 1 failures, 0 errors, 0 skips
Updated by znz (Kazuhiro NISHIYAMA) over 3 years ago
- ruby -v set to ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux]
reported in [ruby-dev:37919], failed when path of source tree includes '-'.
Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago
I've found that test/rdoc/test_rdoc_markup_to_html_crossref.rb fails when full-path of source tree
contains '-', like "/usr/local/src/ruby-trunk/".
I have a tiny patch solves this test failure.
I'm not confident it's right way to fix the problem. Please examine it.
===================================================================
--- lib/rdoc/markup/to_html_crossref.rb (revision 22068)
+++ lib/rdoc/markup/to_html_crossref.rb (working copy)
@@ -65,7 +65,7 @@
# The key thing is that there must be at least
# one special character (period, slash, or
# underscore).
- | [\/\w]+[_\/\.][\w\/\.]+
+ | [-\/\w]+[_\/\.][-\w\/\.]+
# Things that have markup suppressed
| \\[^\s]
Updated by nobu (Nobuyoshi Nakada) about 3 years ago
Hi, At Wed, 17 Dec 2008 00:30:45 +0900, Kazuhiro NISHIYAMA wrote in [ruby-core:20599]: > another failure example: > > % cd test > % ruby-trunk ../test/rdoc/test_rdoc_markup_to_html_crossref.rb > nil > Loaded suite ../test/rdoc/test_rdoc_markup_to_html_crossref > Started > F > Finished in 0.058379 seconds. > > 1) Failure: > test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [../test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]: > Expected "<p> <a href=\"../files/__/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html\">../test/rdoc/rdoc_markup_to_html_crossref_reference.rb</a> </p> ", not "<p> ../test/rdoc/rdoc_markup_to_html_crossref_reference.rb </p> ". > > 1 tests, 29 assertions, 1 failures, 0 errors, 0 skips Assuming the test is correct. Index: lib/rdoc/markup/to_html_crossref.rb =================================================================== --- lib/rdoc/markup/to_html_crossref.rb (revision 22822) +++ lib/rdoc/markup/to_html_crossref.rb (working copy) @@ -66,5 +66,5 @@ class RDoc::Markup::ToHtmlCrossref < RDo # one special character (period, slash, or # underscore). - | [\/\w]+[_\/\.][\w\/\.]+ + | (?:\.\.\/)*[-\/\w]+[_\/\.][-\w\/\.]+ # Things that have markup suppressed -- Nobu Nakada
Updated by drbrain (Eric Hodel) almost 3 years ago
I have applied Nobu's patch to RDoc trunk.
Updated by marcandre (Marc-Andre Lafortune) over 2 years ago
- Status changed from Open to Assigned
- Target version set to 1.9.2
Updated by naruse (Yui NARUSE) over 2 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r26386. Kazuhiro, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you.