Bug #2385

Re: Ruby:r25230 (ruby_1_8, trunk): * marshal.c (struct {dump,load}_arg): manage with dfree, instead

Added by Shyouhei Urabe about 2 years ago. Updated 10 months ago.

[ruby-dev:39723]
Status:Closed Start date:
Priority:Low Due date:
Assignee:Nobuyoshi Nakada % Done:

100%
Category:-
Target version:Ruby 1.8.8
ruby -v:

Description

nobu@ruby-lang.org さんは書きました:
> nobu	2009-10-04 19:30:56 +0900 (Sun, 04 Oct 2009)
> 
>   New Revision: 25230
> 
>   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=25230
> 
>   Log:
>     * marshal.c (struct {dump,load}_arg): manage with dfree, instead
>       of using local variable which may be moved by context switch.
>       [ruby-dev:39425]
> 
>   Modified files:
>     branches/ruby_1_8/ChangeLog
>     branches/ruby_1_8/marshal.c
>     branches/ruby_1_8/test/ruby/test_marshal.rb
>     trunk/ChangeLog
>     trunk/marshal.c
>     trunk/test/ruby/test_marshal.rb

このリビジョンをバックポートしようかと思い精査したのですが、これが入ってから
1.8.8devのmake test-allが1F増えています。デグレードなんじゃないでしょうか。

該当の差分:
http://www.rubyist.net/~akr/chkbuild/debian/ruby-1.8/log/20091005T001857.diff.txt.gz

なお1.8.7にr25230をあてたものだと1F0Eになります。

Associated revisions

Revision 25995
Added by nobu about 2 years ago

* marshal.c (marshal_load): should set taintness. [ruby-dev:39723]

History

#1
Updated by Shyouhei Urabe about 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to Nobuyoshi Nakada
  • Target version set to Ruby 1.8.8

#2
Updated by Nobuyoshi Nakada about 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r25995.
Shyouhei, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

Also available in: Atom PDF