Bug #2555

"case n when *VALID" Broken in Ruby 1.8.8; affects Ruby on Rails

Added by Sam Ruby about 2 years ago. Updated 10 months ago.

[ruby-core:27395]
Status:Closed Start date:01/05/2010
Priority:Urgent Due date:
Assignee:- % Done:

0%
Category:core
Target version:-
ruby -v:ruby 1.8.8dev (2010-01-01 revision 26226) [x86_64-linux]

Description

This affects uses of the "builder" gem.

Related commits:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=24695
http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=25658

Results when run against selected versions of 1.8.8:

ruby 1.8.8dev (2009-08-26 revision 24669) [x86_64-linux]
<a>a</a>
valid
valid

ruby 1.8.8dev (2009-08-26 revision 24695) [x86_64-linux]
<a>*</a>
INVALID
INVALID

ruby 1.8.8dev (2009-11-05 revision 25657) [x86_64-linux]
<a>*</a>
INVALID
INVALID

ruby 1.8.8dev (2009-11-05 revision 25658) [x86_64-linux]
<a>*</a>
valid
INVALID

valid.rb (562 Bytes) Sam Ruby, 01/05/2010 03:01 am

Related issues

related to Ruby 1.8 - Bug #2468: Array expansion inside case/when gives unexpected results Closed 12/10/2009
duplicates Ruby 1.8 - Bug #2551: case/when matches literal *[1,2,3] but not variable *ary Closed 01/03/2010

History

#1
Updated by Sam Ruby about 2 years ago

I should have mentioned that the attachment is the test case.

#2
Updated by Jeremy Kemper about 2 years ago

Duplicates #2551, #2468.

#3
Updated by Akinori MUSHA about 2 years ago

  • Status changed from Open to Closed
This issue was solved with changeset r26589.
Romulo, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

#4
Updated by Sam Ruby about 2 years ago

The test case provided still fails.

As near as I can tell, changeset r26589 only contains test cases, but no changes to Ruby itself.

Please reopen this bug.

#5
Updated by Akinori MUSHA about 2 years ago

I never meant to close this.

I wish "ref [Bug #...]" would have been parsed just like "cf: [Bug #...]".

#6
Updated by Marc-Andre Lafortune about 2 years ago

  • Category set to core
  • Status changed from Closed to Open

#7
Updated by Sam Ruby almost 2 years ago

http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=26737 reverts http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=24695 and addresses this problem.  This issue can be closed at this time.

#8
Updated by Yui NARUSE almost 2 years ago

  • Status changed from Open to Closed
> I wish "ref [Bug #...]" would have been parsed just like "cf: [Bug #...]".
#... may change when the ticket moves from bug to backport or something.
So writing ref #... is correct.

Also available in: Atom PDF