Bug #2640

signal code only needs slight changes to make Ruby compile on Haiku-os

Added by Alexander von Gluck about 2 years ago. Updated 9 months ago.

[ruby-core:27768]
Status:Third Party's Issue Start date:01/25/2010
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:build
Target version:-
ruby -v:1.9.1

Description

gcc -O2 -g -Wall -Wno-parentheses  -I. -I.ext/include/i586-haiku -I./include -I.  -DRUBY_EXPORT   -o signal.o -c signal.c
signal.c: In function 'sigsegv':
signal.c:593: error: 'info' undeclared (first use in this function)
signal.c:593: error: (Each undeclared identifier is reported only once
signal.c:593: error: for each function it appears in.)
make: *** [signal.o] Error 1

commenting out the sigsegv handling code lets ruby 1.9 compile successfully on Haiku-os.  This is not a valid solution but does show how close 1.9 is to running on the Haiku platform.

Associated revisions

Revision 26399
Added by Nobuyoshi Nakada about 2 years ago

* signal.c (USE_SIGALTSTACK): only when SA_SIGINFO also is available. see [ruby-core:27768].

History

#1
Updated by Yui NARUSE about 2 years ago

  • Category set to build
Please try the patch in following page.
http://znz.s1.xrea.com/t/?date=20090926

#2
Updated by Nobuyoshi Nakada about 2 years ago

Hi,

At Mon, 25 Jan 2010 10:30:30 +0900,
Alexander von Gluck wrote in [ruby-core:27768]:
> signal.c: In function 'sigsegv':
> signal.c:593: error: 'info' undeclared (first use in this function)
> signal.c:593: error: (Each undeclared identifier is reported only once
> signal.c:593: error: for each function it appears in.)
> make: *** [signal.o] Error 1

It means sigaltstack() is found but SA_SIGINFO isn't.  Haiku-OS
doesn't provide the flag?  Or does it need another header?

-- 
Nobu Nakada

#3
Updated by Alexander von Gluck about 2 years ago

@Yui

That patch definitely looks like it would resolve this issue.  Since that info structure is a todo for the Haiku project the code should probably be left as-is until Haiku completes it.

Thanks!
 -- Alex

#4
Updated by Yui NARUSE about 2 years ago

  • Status changed from Open to Third Party's Issue
Hmm, if so, this is not Ruby's issue.
If Haiku 1.0 still doesn't have them, please reopen this; we may apply the patch.

#5
Updated by Alexander von Gluck about 2 years ago

The patch suggested at http://znz.s1.xrea.com/t/?date=20090926 causes the bus error for me too and seems like an invalid work-around.

The overall solution for this issue is on Haiku's side and not Ruby's fault.
http://dev.haiku-os.org/ticket/2695

Until Haiku fixes this I'll just comment out the broken call which seems to work and make a miniruby that works :). Just a quick note that this patch may cause some bad mojo on a sigsegv and should not be used in production apps.


Index: signal.c
===================================================================
--- signal.c    (revision 26395)
+++ signal.c    (working copy)
@@ -34,7 +34,7 @@
 # define ATOMIC_DEC(var) (--(var))
 #endif

-#ifdef __BEOS__
+#if defined(__BEOS__) || defined(__HAIKU__)
 #undef SIGBUS
 #endif

@@ -597,6 +597,7 @@
 static RETSIGTYPE
 sigsegv(int sig SIGINFO_ARG)
 {
+/*
 #ifdef USE_SIGALTSTACK
     int ruby_stack_overflowed_p(const rb_thread_t *, const void *);
     NORETURN(void ruby_thread_stack_overflow(rb_thread_t *th));
@@ -605,6 +606,7 @@
        ruby_thread_stack_overflow(th);
     }
 #endif
+*/
     if (segv_received) {
        fprintf(stderr, "SEGV received in SEGV handler\n");
        exit(EXIT_FAILURE);

#6
Updated by Alexander von Gluck about 2 years ago

Looks like Nobuyoshi Nakada fixed this in r26399

logic: if no SIGSEGV info, don't USE_SIGALTSTACK

That should be generic, way to be smarter then the Operating system :)

can be closed.

Also available in: Atom PDF