Bug #2960

svn revision detection of git-based repo on Windows is broken

Added by Vladimir Sizikov almost 2 years ago. Updated 10 months ago.

[ruby-core:28651]
Status:Closed Start date:03/14/2010
Priority:Normal Due date:
Assignee:- % Done:

100%
Category:build
Target version:-
ruby -v:ruby 1.9.2dev (2010-03-14) [i386-mingw32]

Description

This leads to situation when MRI built on Windows from git-based repo doesn't show the actual SVN revision: ruby 1.9.2dev (2010-03-14) [i386-mingw32]

This is a regression caused by recent changes in file2lastrev.rb file.

Attached is a small patch that fixes the problem for me on Windows. And I checked that it works on Linux as well.

0001-Fix-svn-revison-detection-of-git-based-repo-on-Windo.patch - Small patch to resolve the problem. (799 Bytes) Vladimir Sizikov, 03/14/2010 07:35 pm

Associated revisions

Revision 26917
Added by Yui NARUSE almost 2 years ago

* tool/file2lastrev.rb (VCS::GIT_SVN#get_revisions) : use block argument 'path' to get the path given by super. * tool/file2lastrev.rb (VCS::GIT#get_revisions): use double quotes for Windows. patched by Vladimir Sizikov [ruby-core:28651]

History

#1
Updated by Yui NARUSE almost 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r26917.
Vladimir, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

Also available in: Atom PDF