Ruby » ruby-trunk

Yeah I wouldn't call this a high priority ticket.

gem_prelude.rb:push_all_highest_version_gems_on_load_path expects gem
directory names to be "#{GEMNAME}-#{VERSION}", but the native gem
directory name is suffixed by the platform name.

The following patch may help or may not.


diff --git a/gem_prelude.rb b/gem_prelude.rb
index 71f30bd..3be64aa 100644
--- a/gem_prelude.rb
+++ b/gem_prelude.rb
@@ -229,8 +229,12 @@ if defined?(Gem) then
             Dir.entries(gems_directory).each do |gem_directory_name|
               next if gem_directory_name == "." || gem_directory_name == ".."

-              next unless gem_name = gem_directory_name[/(.*)-(.*)/, 1]
+              next unless gem_name = gem_directory_name[/(.*)-(\d+(?:\.\d+)*)(?:-(.*))?/, 1]
               new_version = integers_for($2)
+              if platform = $3
+                require 'rubygems/platform'
+                Gem::Platform.match(platform) or next
+              end
               current_version = GemVersions[gem_name]

               if !current_version or (current_version <=> new_version) < 0 then

On Jul 20, 2010, at 6:25 AM, Yusuke Endoh wrote:

> Issue #3462 has been updated by Yusuke Endoh.
> 
> Assigned to changed from Eric Hodel to Evan Phoenix
> 
> Hi, Evan
> 
> This ticket is about gem_prelude.rb.
> Do you think this should be fixed in 1.9.2?
> And what do you think about nobu's patch?

Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.

If we can apply the patch to 1.9.2, we should.

 - Evan

> 
> -- 
> Yusuke Endoh <mame@tsg.ne.jp>
> ----------------------------------------
> http://redmine.ruby-lang.org/issues/show/3462
> 
> ----------------------------------------
> http://redmine.ruby-lang.org
> 
> 

Hi,

2010/7/21 Evan Phoenix <evan@fallingsnow.net>:
>> Hi, Evan
>>
>> This ticket is about gem_prelude.rb.
>> Do you think this should be fixed in 1.9.2?
>> And what do you think about nobu's patch?
>
> Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.
>
> If we can apply the patch to 1.9.2, we should.


Thank you for your quick reply!

Did you get a commit bit?  If you did, could you apply it to
trunk and check "make test-rubyspec" and "make check"?
If you see no problem, please commit it to trunk.

If no problem is reported in a few days, I'll backport it to
ruby_1_9_2.

-- 
Yusuke Endoh <mame@tsg.ne.jp>

On Jul 20, 2010, at 9:32 AM, Yusuke Endoh wrote:

> Issue #3462 has been updated by Yusuke Endoh.
> 
> 
> Hi,
> 
> 2010/7/21 Evan Phoenix <evan@fallingsnow.net>:
>>> Hi, Evan
>>> 
>>> This ticket is about gem_prelude.rb.
>>> Do you think this should be fixed in 1.9.2?
>>> And what do you think about nobu's patch?
>> 
>> Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.
>> 
>> If we can apply the patch to 1.9.2, we should.
> 
> 
> Thank you for your quick reply!

No problem!

> 
> Did you get a commit bit?  If you did, could you apply it to
> trunk and check "make test-rubyspec" and "make check"?
> If you see no problem, please commit it to trunk.

Yep! I've got a commit bit now, I'll apply to trunk and commit it if it's fine.

> 
> If no problem is reported in a few days, I'll backport it to
> ruby_1_9_2.

Wonderful!

> 
> -- 
> Yusuke Endoh <mame@tsg.ne.jp>
> ----------------------------------------
> http://redmine.ruby-lang.org/issues/show/3462
> 
> ----------------------------------------
> http://redmine.ruby-lang.org
> 
> 

I've committed a slightly revised version of the patch that nobu and I worked on into trunk. It solves the gem activation issues because it loads all of rubygems to perform any gem activation.

Hopefully we can have this backported to 1.9.2 soon.

Thanks!

 - Evan

On Jul 20, 2010, at 9:34 AM, Evan Phoenix wrote:

> 
> On Jul 20, 2010, at 9:32 AM, Yusuke Endoh wrote:
> 
>> Issue #3462 has been updated by Yusuke Endoh.
>> 
>> 
>> Hi,
>> 
>> 2010/7/21 Evan Phoenix <evan@fallingsnow.net>:
>>>> Hi, Evan
>>>> 
>>>> This ticket is about gem_prelude.rb.
>>>> Do you think this should be fixed in 1.9.2?
>>>> And what do you think about nobu's patch?
>>> 
>>> Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.
>>> 
>>> If we can apply the patch to 1.9.2, we should.
>> 
>> 
>> Thank you for your quick reply!
> 
> No problem!
> 
>> 
>> Did you get a commit bit?  If you did, could you apply it to
>> trunk and check "make test-rubyspec" and "make check"?
>> If you see no problem, please commit it to trunk.
> 
> Yep! I've got a commit bit now, I'll apply to trunk and commit it if it's fine.
> 
>> 
>> If no problem is reported in a few days, I'll backport it to
>> ruby_1_9_2.
> 
> Wonderful!
> 
>> 
>> -- 
>> Yusuke Endoh <mame@tsg.ne.jp>
>> ----------------------------------------
>> http://redmine.ruby-lang.org/issues/show/3462
>> 
>> ----------------------------------------
>> http://redmine.ruby-lang.org
>> 
>> 
> 
> 
> 

Seems to work now. Since it doesn't pre-load $: with any gem lib paths anymore, probably quite a bit of gem_prelude could now be removed as well.

Thanks much.
-r