Bug #897

Kenel#describe should be private in minitest/spec

Added by okkez _ about 3 years ago. Updated 10 months ago.

[ruby-core:20611]
Status:Closed Start date:12/17/2008
Priority:Normal Due date:12/24/2008
Assignee:Ryan Davis % Done:

0%
Category:lib
Target version:1.9.1 Release Candidate
ruby -v:

Description

I think Kernel#describe should be private.

code:
# OK
describe 'aaa' do
  do_something
end

# NG (I think that this code should raise an exception)
99.describe 'bbb' do
  do_something
end

patch:

Index: lib/minitest/spec.rb
===================================================================
--- lib/minitest/spec.rb        (revision 20785)
+++ lib/minitest/spec.rb        (working copy)
@@ -54,6 +54,7 @@
 end

 module Kernel
+  private
   def describe desc, &block
     cls = Class.new(MiniTest::Spec)
     Object.const_set desc.to_s.split(/\W+/).map { |s| s.capitalize }.join, cls

History

#1
Updated by Yuki Sonoda about 3 years ago

  • Due date set to 12/24/2008
  • Target version set to 1.9.1 Release Candidate

#2
Updated by Ryan Davis about 3 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF