From d8f59b3ba7ec8540c9f186d057bb31753d5fb43c Mon Sep 17 00:00:00 2001 From: Seiei Higa Date: Mon, 12 Jan 2015 05:28:08 +0900 Subject: [PATCH] vm_method.c: raise a NameError when create alias to refined new method * vm_method.c (rb_alias): raise a NameError when create alias to refined method if the original method of the refined method is not defined. [ruby-core:67523] [Bug #10731] --- test/ruby/test_refinement.rb | 25 +++++++++++++++++++++++++ vm_method.c | 4 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/test/ruby/test_refinement.rb b/test/ruby/test_refinement.rb index 7973b1a..884d031 100644 --- a/test/ruby/test_refinement.rb +++ b/test/ruby/test_refinement.rb @@ -1192,6 +1192,31 @@ def foo end; end + def test_alias_refined_method + assert_separately([], <<-"end;") + bug10731 = '[ruby-core:67523] [Bug #10731]' + + class C + end + + module RefinementBug + refine C do + def foo + end + + def bar + end + end + end + + assert_raise(NameError, bug10731) do + class C + alias foo bar + end + end + end; + end + private def eval_using(mod, s) diff --git a/vm_method.c b/vm_method.c index 289c77a..a406612 100644 --- a/vm_method.c +++ b/vm_method.c @@ -1278,7 +1278,9 @@ rb_alias(VALUE klass, ID name, ID def) again: orig_me = search_method(klass, def, &defined_class); - if (UNDEFINED_METHOD_ENTRY_P(orig_me)) { + if (UNDEFINED_METHOD_ENTRY_P(orig_me) || + (orig_me->def->type == VM_METHOD_TYPE_REFINED && + UNDEFINED_METHOD_ENTRY_P(orig_me->def->body.orig_me))) { if ((!RB_TYPE_P(klass, T_MODULE)) || (orig_me = search_method(rb_cObject, def, 0), UNDEFINED_METHOD_ENTRY_P(orig_me))) { -- 2.2.1