From 2d2f34daf8564aa45ff89845cd2452e4e0275360 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 14 Jun 2019 16:53:42 -0700 Subject: [PATCH] Raise TypeError if calling ENV.freeze Previously, you could call ENV.freeze, but it would not have the desired effect, as you could still modify ENV. --- hash.c | 15 +++++++++++++++ test/ruby/test_env.rb | 4 ++++ 2 files changed, 19 insertions(+) diff --git a/hash.c b/hash.c index 2982afad9d..3aa736e29b 100644 --- a/hash.c +++ b/hash.c @@ -5699,6 +5699,20 @@ env_reject(void) return rb_hash_delete_if(env_to_hash()); } +/* + * call-seq: + * ENV.freeze -> raises TypeError + * + * Ruby does not allow ENV to be frozen, so calling ENV.freeze + * raises TypeError. + */ +static VALUE +env_freeze(VALUE self) +{ + rb_raise(rb_eTypeError, "cannot freeze ENV"); + return self; /* Not reached */ +} + /* * call-seq: * ENV.shift -> Array or nil @@ -6056,6 +6070,7 @@ Init_Hash(void) rb_define_singleton_method(envtbl, "filter", env_select, 0); rb_define_singleton_method(envtbl, "filter!", env_select_bang, 0); rb_define_singleton_method(envtbl, "shift", env_shift, 0); + rb_define_singleton_method(envtbl, "freeze", env_freeze, 0); rb_define_singleton_method(envtbl, "invert", env_invert, 0); rb_define_singleton_method(envtbl, "replace", env_replace, 1); rb_define_singleton_method(envtbl, "update", env_update, 1); diff --git a/test/ruby/test_env.rb b/test/ruby/test_env.rb index 6343642ac1..e8ae762d03 100644 --- a/test/ruby/test_env.rb +++ b/test/ruby/test_env.rb @@ -496,6 +496,10 @@ def test_win32_blocksize end end + def test_frozen + assert_raise(TypeError) { ENV.freeze } + end + def test_frozen ENV[PATH_ENV] = "/" ENV.each do |k, v| -- 2.21.0