https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112014-07-18T05:54:15ZRuby Issue Tracking SystemRuby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478482014-07-18T05:54:15Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul></ul><p>Please split new feature and tests into another issue.</p> Ruby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478502014-07-18T08:18:13Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>@ Hiroshi SHIBATA さん</p>
<p>I split patch "reorder_Matrix#real_and_Matrix_imaginary.patch" to <a href="https://bugs.ruby-lang.org/issues/10058" class="external">https://bugs.ruby-lang.org/issues/10058</a></p>
<p>How can I delete patch from feature ?</p>
<p>承知致しました.</p>
<p>7つのPATCHの内、"reorder_Matrix#real_and_Matrix_imaginary.patch"</p>
<p>はこちら <a href="https://bugs.ruby-lang.org/issues/10058" class="external">https://bugs.ruby-lang.org/issues/10058</a> に切り出させて頂きました.</p>
<p>一度featureに添付したPATCHは削除出来ないのでしょうか.</p> Ruby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478512014-07-18T08:37:01Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>File</strong> deleted (<del><i>reorder_Matrix#real_and_Matrix_imaginary.patch</i></del>)</li></ul> Ruby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478522014-07-18T08:48:13Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset r46861.</p>
<hr>
<ul>
<li>test/matrix/test_matrix.rb: Add tests for Matrix class.<br>
[Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: [PATCH] Add tests for Matrix class. (Closed)" href="https://bugs.ruby-lang.org/issues/10057">#10057</a>]<a href="/issues/10057">[ruby-core:63809]</a></li>
</ul> Ruby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478562014-07-18T09:57:26Zmarcandre (Marc-Andre Lafortune)marcandre-ruby-core@marc-andre.ca
<ul></ul><p>Gogo Tanaka san,</p>
<p>Thanks for these additional tests.</p>
<p>Please note that the vast majority of tests of the Matrix library are in RubySpec: <a href="https://github.com/rubysl/rubysl-matrix" class="external">https://github.com/rubysl/rubysl-matrix</a></p>
<p>I hope you'll find them extensive, having for instance many more tests than found in this patch <code>imaginary</code>. If you'd like to port them this would be great.</p> Ruby master - Feature #10057: [PATCH] Add tests for Matrix class.https://bugs.ruby-lang.org/issues/10057?journal_id=478662014-07-18T17:13:47Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>@ Hiroshi SHIBATA さん</p>
<p>ファイルの削除や進捗、ステータスのハンドリングありがとうございます.</p>
<p>Thank you for your some supports.</p>
<p>@ Mr. Marc-Andre Lafortune</p>
<p>I don't know that ... ! it's great! Thank you for your kindness!!!</p>