https://bugs.ruby-lang.org/
https://bugs.ruby-lang.org/favicon.ico?1711330511
2014-08-08T23:56:25Z
Ruby Issue Tracking System
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=48264
2014-08-08T23:56:25Z
nobu (Nobuyoshi Nakada)
nobu@ruby-lang.org
<ul><li><strong>Subject</strong> changed from <i>[PATCH] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command</i> to <i>[PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/48264/diff?detail_id=34858">diff</a>)</li></ul>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=48304
2014-08-12T03:44:13Z
hsbt (Hiroshi SHIBATA)
hsbt@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li></ul>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=50849
2015-01-08T02:31:48Z
shugo (Shugo Maeda)
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Feedback</i></li></ul><p>It seems to be a bug that store_internal is changed not to use flags.<br>
What was your intention?</p>
<p>Could you write tests for this change?</p>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=64745
2017-05-10T15:21:16Z
plehoux (Philippe-Antoine Lehoux)
plehoux@gmail.com
<ul><li><strong>File</strong> <i>modseq-changedsince-changes-UPDATED.patch</i> added</li></ul><p>The above patch was wrong. There is/was no flags variable in current/previous ruby versions.</p>
<p>The attached patch now correctly reflect the real diff.</p>
<p>I also added this test as requested:</p>
<pre><code class="ruby syntaxhl" data-language="ruby"> <span class="c1"># [Bug #10119]</span>
<span class="k">def</span> <span class="nf">test_msg_att_modseq_data</span>
<span class="n">parser</span> <span class="o">=</span> <span class="no">Net</span><span class="o">::</span><span class="no">IMAP</span><span class="o">::</span><span class="no">ResponseParser</span><span class="p">.</span><span class="nf">new</span>
<span class="n">response</span> <span class="o">=</span> <span class="n">parser</span><span class="p">.</span><span class="nf">parse</span><span class="p">(</span><span class="s2">"* 1 FETCH (FLAGS (</span><span class="se">\S</span><span class="s2">een) MODSEQ (12345) UID 5)</span><span class="se">\r\n</span><span class="s2">"</span><span class="p">)</span>
<span class="n">assert_equal</span><span class="p">(</span><span class="mi">12345</span><span class="p">,</span> <span class="n">response</span><span class="p">.</span><span class="nf">data</span><span class="p">.</span><span class="nf">attr</span><span class="p">[</span><span class="s2">"MODSEQ"</span><span class="p">])</span>
<span class="k">end</span>
</code></pre>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=64747
2017-05-10T17:05:12Z
plehoux (Philippe-Antoine Lehoux)
plehoux@gmail.com
<ul><li><strong>File</strong> deleted (<del><i>modseq-changedsince-changes-UPDATED.patch</i></del>)</li></ul>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=64748
2017-05-10T17:11:13Z
plehoux (Philippe-Antoine Lehoux)
plehoux@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/6535">modseq-changedsince-changes-UPDATED.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6535/modseq-changedsince-changes-UPDATED.patch">modseq-changedsince-changes-UPDATED.patch</a> added</li></ul><p>I updated the patch so the code doesn't raise when passing a CHANGEDSINCE value bigger than 4294967296, as defined by rfc 4551.</p>
<p><a href="https://tools.ietf.org/html/rfc4551" class="external">https://tools.ietf.org/html/rfc4551</a> :</p>
<p>mod-sequence-value = 1*DIGIT<br>
;; Positive unsigned 64-bit integer<br>
;; (mod-sequence)<br>
;; (1 <= n < 18,446,744,073,709,551,615)</p>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=65851
2017-07-19T21:54:53Z
shugo (Shugo Maeda)
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Assigned</i></li></ul>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=65932
2017-07-26T07:47:42Z
shugo (Shugo Maeda)
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r59424.</p>
<hr>
<p>lib/net/imap.rb: support CHANGEDSINCE and MODSEQ</p>
<p>Patch by plehoux (Philippe-Antoine Lehoux). <a href="/issues/10119">[ruby-core:64272]</a> [Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item i... (Closed)" href="https://bugs.ruby-lang.org/issues/10119">#10119</a>]</p>
Ruby master - Feature #10119: [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
https://bugs.ruby-lang.org/issues/10119?journal_id=65933
2017-07-26T07:48:12Z
shugo (Shugo Maeda)
<ul></ul><p>plehoux (Philippe-Antoine Lehoux) wrote:</p>
<blockquote>
<p>I updated the patch so the code doesn't raise when passing a CHANGEDSINCE value bigger than 4294967296, as defined by rfc 4551.</p>
</blockquote>
<p>I've merged it. Thank you!</p>