https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112014-11-08T19:57:28ZRuby Issue Tracking SystemRuby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=498482014-11-08T19:57:28Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>Only my concern is constant <code>E</code> can be overrided.</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=498792014-11-10T22:39:11Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>Associated revision <a href="https://bugs.ruby-lang.org/issues/10255" class="external">10255</a></p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=501852014-11-29T20:26:39Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>ping</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=505022014-12-19T02:56:49Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>ping</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=505032014-12-19T04:00:07Zmarcandre (Marc-Andre Lafortune)marcandre-ruby-core@marc-andre.ca
<ul></ul><p>Looks good. I would use <code>::Math::E</code> instead of <code>E</code> for explicitness (I doubt anyone would defined <code>CMath::E</code>.<br>
Also, bug fixes don't need a NEWS entry.</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=505402014-12-21T08:17:11Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul></ul><p>@Marc-Andre Lafortune</p>
<p>sounds good, do I need to modify patch as you said?<br>
If so, please feel free.</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=507722015-01-03T15:13:29Zayumin (Ayumu AIZAWA)ayumu.aizawa@gmail.com
<ul></ul><p>Hi Tanaka-san<br>
Please post new patch which was applied Marc's review.<br>
I would help you for assign the right person of ruby-core for this issue.<br>
Regards.</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=512332015-01-27T02:30:04Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul><li><strong>File</strong> <a href="/attachments/5030">modify_cmath_rb_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5030/modify_cmath_rb_v2.patch">modify_cmath_rb_v2.patch</a> added</li></ul><p>@Ayumu AIZAWA san</p>
<p>Thank you so much! Here you are.</p> Ruby master - Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.https://bugs.ruby-lang.org/issues/10487?journal_id=516452015-02-24T23:53:46Zgogotanaka (Kazuki Tanaka)mail@tanakakazuki.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset r49729.</p>
<hr>
<ul>
<li>lib/cmath.rb (log): raise ArgumentError when more than 2 arguments<br>
are passed. <a href="/issues/10487">[ruby-core:66143]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense. (Closed)" href="https://bugs.ruby-lang.org/issues/10487">#10487</a>]</li>
</ul>