https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112015-11-17T14:19:35ZRuby Issue Tracking SystemRuby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=548972015-11-17T14:19:35Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul><li><strong>Subject</strong> changed from <i>errors in tests of logger </i> to <i>errors in tests of logger on Windows</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>sonots (Naotoshi Seo)</i></li></ul> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=548982015-11-17T14:23:06Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul></ul><p>One more request.<br>
Date and time of the entry of ChangeLog is not a date and time that you have made the changes,<br>
but the timing of commit to the repository of ruby.</p> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=548992015-11-17T15:34:20Zsonots (Naotoshi Seo)sonots@gmail.com
<ul></ul><p>Oh, god. Thank you for pointing out. I will fix soon.</p> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=549042015-11-17T19:27:21Zsonots (Naotoshi Seo)sonots@gmail.com
<ul></ul><p>@Usaku Nakamura</p>
<p>I created a patch > <a href="https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c" class="external">https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c</a>. Cloud you check this?</p>
<p>I tried to create a build environment for Windows, but unfortunately it failed as <a href="https://gist.github.com/sonots/49e1830d7db19aef505b" class="external">https://gist.github.com/sonots/49e1830d7db19aef505b</a>, and I could not verify by myself.</p> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=549122015-11-17T23:50:12Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul></ul><p>Naotoshi Seo wrote:</p>
<blockquote>
<p>I created a patch > <a href="https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c" class="external">https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c</a>. Cloud you check this?</p>
</blockquote>
<p>Seems OK.<br>
Commit it, please.</p>
<blockquote>
<p>I tried to create a build environment for Windows, but unfortunately it failed as <a href="https://gist.github.com/sonots/49e1830d7db19aef505b" class="external">https://gist.github.com/sonots/49e1830d7db19aef505b</a>, and I could not verify by myself.</p>
</blockquote>
<p>Current trunk does NOT support VS2015.<br>
Naruse-san tried before, and the results is here: <a href="https://github.com/nurse/ruby/tree/msvc14" class="external">https://github.com/nurse/ruby/tree/msvc14</a><br>
But, IMO, you should try vs2013 or mingw, unless you want to be maintain vs2015 build.</p> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=549142015-11-18T00:53:25Zsonots (Naotoshi Seo)sonots@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Applied in changeset r52628.</p>
<hr>
<ul>
<li>test/logger/test_logdevice.rb: Fix tests of logger to make it work on<br>
windows (windows can not remove opened file) [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: errors in tests of logger on Windows (Closed)" href="https://bugs.ruby-lang.org/issues/11702">#11702</a>]</li>
</ul> Ruby master - Bug #11702: errors in tests of logger on Windowshttps://bugs.ruby-lang.org/issues/11702?journal_id=549152015-11-18T00:55:46Zsonots (Naotoshi Seo)sonots@gmail.com
<ul></ul><p>Thanks, I will try with vs2013, but anyway committed :)</p>