https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112015-12-19T07:27:13ZRuby Issue Tracking SystemRuby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556652015-12-19T07:27:13Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul></ul><p>While this case is fixable by <a href="https://github.com/erikhuda/thor/pull/512" class="external">https://github.com/erikhuda/thor/pull/512</a>, there may be some gems depending on the eoutvar's behavior.<br>
If "Pass the name of the variable to be used inside a String" is specification, r53123 should be breaking change and I have no objection to revert the patch.</p> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556682015-12-19T12:09:56Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul></ul><p>What's affected gems without thor?</p> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556692015-12-19T12:26:34Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul></ul><p>I saw rails's build is also broken due to thor. These are all I know for now.<br>
By the way, since my patch to thor <a href="https://github.com/erikhuda/thor/pull/512" class="external">https://github.com/erikhuda/thor/pull/512</a> was merged, now thor master has no problem about this.</p> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556922015-12-20T06:37:17Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset r53216.</p>
<hr>
<ul>
<li>lib/erb.rb: revert r53123. It break compatibility like thor and rspec-rails.<br>
We should try with Ruby 2.4 or 3.0.<br>
[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: r53123 breaks some gems which use erb (Closed)" href="https://bugs.ruby-lang.org/issues/11842">#11842</a>]<a href="/issues/11842">[ruby-core:72374]</a></li>
<li>lib/rdoc/erb_partial.rb: ditto.</li>
<li>template/verconf.h.tmpl: ditto.</li>
</ul> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556932015-12-20T06:39:45Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul></ul><p>I found same case with rspec-rails in latest gems registered rubygems.org. It is widely used application development. I decided to revert r53123.</p>
<blockquote>
<p>Takashi Kokubun</p>
</blockquote>
<p>We will try next release. Thank you for your investigation.</p> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=556942015-12-20T07:18:10Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul></ul><p>I see. Thank you for finding a gem which is widely used and has incompatibility about this.<br>
I hope we will try this in later release.</p> Ruby master - Bug #11842: r53123 breaks some gems which use erbhttps://bugs.ruby-lang.org/issues/11842?journal_id=568642016-02-03T10:36:42Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul><li><strong>Backport</strong> changed from <i>2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN</i> to <i>2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONTNEED</i></li></ul>