https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112016-06-13T14:53:58ZRuby Issue Tracking SystemRuby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=591982016-06-13T14:53:58Zmrkn (Kenta Murata)muraken@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/6022">rational.c.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6022/rational.c.diff">rational.c.diff</a> added</li></ul><p>Attached patch can fix this issue.</p> Ruby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=591992016-06-13T14:58:30Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>You can use <code>RB_INTEGER_TYPE_P</code> in the trunk.</p> Ruby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=592042016-06-13T15:43:53Zmrkn (Kenta Murata)muraken@gmail.com
<ul></ul><p>Nobuyoshi Nakada wrote:</p>
<blockquote>
<p>You can use <code>RB_INTEGER_TYPE_P</code> in the trunk.</p>
</blockquote>
<p>I forgot it. Thanks.</p> Ruby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=800022019-07-25T15:29:31Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>File</strong> <a href="/attachments/7915">rational-denom-to_int.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/7915/rational-denom-to_int.patch">rational-denom-to_int.patch</a> added</li></ul><p>I'm not sure if this is considered a bug or not. Rational will already try to convert numerator and denominator via <code>to_r</code>. However, if we do want to convert via <code>to_int</code> if <code>to_r</code> is not defined, the attached patch should implement it.</p> Ruby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=881142020-10-22T06:12:22Zmrkn (Kenta Murata)muraken@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>mrkn (Kenta Murata)</i></li></ul><p>I'm working on this at <a href="https://github.com/ruby/ruby/pull/3684" class="external">https://github.com/ruby/ruby/pull/3684</a></p> Ruby master - Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_inthttps://bugs.ruby-lang.org/issues/12485?journal_id=881162020-10-22T09:00:22ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Applied in changeset <a class="changeset" title="rational.c: try converting by to_int in Rational() (#3684) [Bug #12485]" href="https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/d23d5c3130a0944e7e591370cbf8599009318a7c">git|d23d5c3130a0944e7e591370cbf8599009318a7c</a>.</p>
<hr>
<p>rational.c: try converting by to_int in Rational() (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: String#to_i documentation mismatch (Closed)" href="https://bugs.ruby-lang.org/issues/3684">#3684</a>)</p>
<p>[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Kernel.Rational raises TypeError though given denominator returns 1 by to_int (Closed)" href="https://bugs.ruby-lang.org/issues/12485">#12485</a>]</p>