https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17097754782017-01-11T04:41:24ZRuby Issue Tracking SystemRuby master - Feature #13103: [PATCH] random.c: use "__NR_" syscall prefix on Linux (instead of "SYS_")https://bugs.ruby-lang.org/issues/13103?journal_id=624612017-01-11T04:41:24Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:normalperson@yhbt.net" class="email">normalperson@yhbt.net</a> wrote:</p>
<blockquote>
<hr>
<p>Feature <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: [PATCH] random.c: use "__NR_" syscall prefix on Linux (instead of "SYS_") (Open)" href="https://bugs.ruby-lang.org/issues/13103">#13103</a>: [PATCH] random.c: use "<em><em>NR</em>" syscall prefix on Linux (instead of "SYS</em>")<br>
<a href="https://bugs.ruby-lang.org/issues/13103" class="external">https://bugs.ruby-lang.org/issues/13103</a></p>
</blockquote>
<p>Any comments? I may commit, someday...</p> Ruby master - Feature #13103: [PATCH] random.c: use "__NR_" syscall prefix on Linux (instead of "SYS_")https://bugs.ruby-lang.org/issues/13103?journal_id=624662017-01-11T14:44:42Zkosaki (Motohiro KOSAKI)kosaki.motohiro@gmail.com
<ul></ul><p>SYS_getrandom and __NR_getrandom are defined in different headers. but your patch doesn't change any #include directive. It seems odd.</p>
<p>Anyway I have no objection.</p> Ruby master - Feature #13103: [PATCH] random.c: use "__NR_" syscall prefix on Linux (instead of "SYS_")https://bugs.ruby-lang.org/issues/13103?journal_id=624722017-01-11T22:51:48Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:kosaki.motohiro@gmail.com" class="email">kosaki.motohiro@gmail.com</a> wrote:</p>
<blockquote>
<p>SYS_getrandom and __NR_getrandom are defined in different headers. but<br>
your patch doesn't change any #include directive. It seems odd.</p>
</blockquote>
<p>Yes. sys/syscall.h (glibc, libc6-dev on Debian) pulls in<br>
asm/unistd_#{ARCH}.h (provided by Linux kernel headers,<br>
linux-libc-dev on Debian) where NR_* is defined.</p>
<blockquote>
<p>Anyway I have no objection.</p>
</blockquote>
<p>Thanks, r57307</p>