https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17097754782017-02-22T06:17:34ZRuby Issue Tracking SystemRuby master - Feature #13133: TracePoint: Add event type for constant accesshttps://bugs.ruby-lang.org/issues/13133?journal_id=630742017-02-22T06:17:34Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>ko1 (Koichi Sasada)</i></li></ul> Ruby master - Feature #13133: TracePoint: Add event type for constant accesshttps://bugs.ruby-lang.org/issues/13133?journal_id=640772017-04-05T07:10:39Zko1 (Koichi Sasada)
<ul></ul><blockquote>
<p>Enforcing package boundaries is a problem we've been discussing a lot lately at Shopify.</p>
</blockquote>
<p>I understand the issue. But your patch and your design needs more consideration.</p>
<ul>
<li>Your patch provide a hook only on const cache miss, but the name <code>constant_access</code> I assume it hooks all of constant accesses.</li>
<li>Your patch inserts the hook only in insns.def, but C level constant access is available.</li>
<li>Not only constant access, constant setting or reopen class/modules are also needed to analyze (and introduce restriction if needed into ) program behavior.</li>
</ul> Ruby master - Feature #13133: TracePoint: Add event type for constant accesshttps://bugs.ruby-lang.org/issues/13133?journal_id=640832017-04-05T15:43:03Zburke (Burke Libbey)
<ul></ul><p>All good points, thank you. I definitely agree that the implementation is not good. Feel free to close this. I'll see if I can find a better way to accomplish my goals here some other time.</p> Ruby master - Feature #13133: TracePoint: Add event type for constant accesshttps://bugs.ruby-lang.org/issues/13133?journal_id=648972017-05-19T03:06:49Zko1 (Koichi Sasada)
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Rejected</i></li></ul>