https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112017-07-16T23:27:54ZRuby Issue Tracking SystemRuby master - Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacinghttps://bugs.ruby-lang.org/issues/13569?journal_id=658122017-07-16T23:27:54ZMSP-Greg (Greg L)
<ul></ul><p>Decided to re-run this test, as it's been a while. I've been applying the patch before my normal test runs, so I haven't checked for its (continued) failure for a while. Given that my test results have been consistent across all test sets, I doubt I've got something wrong with my env setup during testing.</p>
<p>Note that if I run this test with runner.rb in a windows env, the test passes. But as noted below, it fails when run with make (I set a make env by adding <code>msys64\mingw64\bin</code> and <code>msys64\usr\bin</code> to my path.)</p>
<p>Below is a command window grab from a make test:</p>
<pre><code>E:\GitHub\ruby-loco\src\build-x86_64>make.exe "TESTOPTS= --show-skip ../ruby/test/ruby/test_rubyoptions.rb" test-all
Run options: "--ruby=./miniruby.exe -I../ruby/lib -I. -I.ext/common ../ruby/tool/runruby.rb --extout=.ext -- --disable-gems" --excludes-dir=../ruby/
test/excludes --name=!/memory_leak/ --show-skip
# Running tests:
1) Skipped:
TestRubyOptions#test_set_program_name [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:514]:
platform dependent feature
2) Skipped:
TestRubyOptions#test_setproctitle [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:533]:
platform dependent feature
3) Failure:
TestRubyOptions#test_search [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:303]:
1. [1/2] Assertion for "stdout"
| <["1"]> expected but was
| <[]>.
Finished tests in 18.127200s, 3.0341 tests/s, 47.0564 assertions/s.
55 tests, 853 assertions, 1 failures, 0 errors, 2 skips
ruby -v: ruby 2.5.0dev (2017-07-17 trunk 59347) [x64-mingw32]
make: *** [uncommon.mk:684: yes-test-all] Error 1
</code></pre>
<p>If you cannot repo this, please feel free to respond.</p> Ruby master - Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacinghttps://bugs.ruby-lang.org/issues/13569?journal_id=666222017-09-13T02:42:32Zh.shirosaki (Hiroshi Shirosaki)h.shirosaki@gmail.com
<ul></ul><p>I can reproduce this with msys2 build.<br>
miniruby.exe and ruby.exe have dependency to libgmp-10.dll.<br>
So path which contains libgmp-10.dll is needed to PATH environment variable.</p>
<p>I can avoid the issue by copying libgmp-10.dll to current directory.</p>
<p>It seems that rubyinstaller2 binary uses manifest dependency instead of PATH.<br>
<a href="https://github.com/oneclick/rubyinstaller2/blob/master/recipes/sandbox/60-side-by-side-assembly.rake" class="external">https://github.com/oneclick/rubyinstaller2/blob/master/recipes/sandbox/60-side-by-side-assembly.rake</a></p> Ruby master - Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacinghttps://bugs.ruby-lang.org/issues/13569?journal_id=666232017-09-13T03:06:47ZMSP-Greg (Greg L)
<ul></ul><p>My MinGW builds are very similar to rubyinstaller2 builds, and they also use a manifest. They use the rubyinstaller2 runtime.</p>
<p>Speaking of copying files, I do copy a file for another test, but I didn't note which test it affected...</p>
<pre><code>copy /b .\ext\-test-\win32\dln\dlntest.dll dlntest.dll
</code></pre>
<p>Re the PR, it could be made dependent on RUBY_PLATFORM, etc.</p>
<p>Thank you for reviewing.</p> Ruby master - Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacinghttps://bugs.ruby-lang.org/issues/13569?journal_id=666322017-09-13T17:07:25Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r59870.</p>
<hr>
<p>test_rubyoptions.rb: keep paths if necessary</p>
<ul>
<li>test/ruby/test_rubyoptions.rb (TestRubyOptions#test_search):<br>
PATH must keep library loading paths on a platform where it is<br>
used for that purpose, for extra libraries.<br>
<a href="/issues/13569">[ruby-core:81178]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Windows - TestRubyOptions#test_search - append to paths instead of replacing (Closed)" href="https://bugs.ruby-lang.org/issues/13569">#13569</a>] [Fix GH-1616]</li>
</ul>