https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112017-07-15T16:15:48ZRuby Issue Tracking SystemRuby master - Bug #13748: [PATCH] Fix mul overflow detection for LLP64 arch.https://bugs.ruby-lang.org/issues/13748?journal_id=658092017-07-15T16:15:48ZMSP-Greg (Greg L)
<ul></ul><p>Just updated to gcc 7.1.0, and built trunk <code>ruby 2.5.0dev (2017-07-15 trunk 59341) [x64-mingw32]</code> with Lars' patch, and <strong>all tests results were as expected</strong>.</p>
<p>Build/test logs are at Bintray - <a href="https://dl.bintray.com/msp-greg/ruby_windows/:z_logs_2017-07-15_59341.7z" class="external">z_logs_2017-07-15_59341.7z</a>, build files at <a href="https://dl.bintray.com/msp-greg/ruby_windows/" class="external">ruby_trunk.7z & ruby_trunk.7z.sig</a>.</p>
<p>Test result tables updated at <a href="https://msp-greg.github.io/file.mingw_test-all.html" class="external">Ruby MinGW Test Results</a>. This morning's doc updates to the site (<a href="https://msp-greg.github.io/ruby_trunk/index.html" class="external">Ruby trunk</a> and <a href="https://msp-greg.github.io/rails_master/index.html" class="external">Rails master</a>) were generated using the build.</p>
<p>Lars - thanks again. For those that don't know, Lars is the creator of RubyInstaller2 for Windows. My build system is a little different, but both are MSYS2/MinGW based. My build system uses the runtime files he created for RI2, which allow the installation/compiling of extension gems.</p> Ruby master - Bug #13748: [PATCH] Fix mul overflow detection for LLP64 arch.https://bugs.ruby-lang.org/issues/13748?journal_id=659752017-07-29T16:58:29Zlarskanis (Lars Kanis)
<ul><li><strong>Subject</strong> changed from <i>Fix mul overflow detection for LLP64 arch.</i> to <i>[PATCH] Fix mul overflow detection for LLP64 arch.</i></li></ul> Ruby master - Bug #13748: [PATCH] Fix mul overflow detection for LLP64 arch.https://bugs.ruby-lang.org/issues/13748?journal_id=668792017-09-25T08:19:22Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r60019.</p>
<hr>
<p>Fix overflow detection for LLP64 arch [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [PATCH] Fix mul overflow detection for LLP64 arch. (Closed)" href="https://bugs.ruby-lang.org/issues/13748">#13748</a>]</p>
<p>FIXNUMs are expected to fit into a long type, but the test is about a<br>
VALUE type. Since long is < than VALUE on LLP64, the overflow is not<br>
detected. As a result "2**31" evaluates to "-2147483648" on Windows with<br>
gcc-7.1.0.<br>
patched by Lars Kanis <a href="mailto:lars@greiz-reinsdorf.de" class="email">lars@greiz-reinsdorf.de</a></p> Ruby master - Bug #13748: [PATCH] Fix mul overflow detection for LLP64 arch.https://bugs.ruby-lang.org/issues/13748?journal_id=668802017-09-25T08:20:04Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Backport</strong> changed from <i>2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN</i> to <i>2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED</i></li></ul>