https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112018-06-06T22:09:52ZRuby Issue Tracking SystemRuby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724302018-06-06T22:09:52ZMSP-Greg (Greg L)
<ul><li><strong>File</strong> <a href="/attachments/7192">http.rb.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/7192/http.rb.patch">http.rb.patch</a> added</li><li><strong>ruby -v</strong> changed from <i>ruby -v: ruby 2.6.0dev (2018-06-06 trunk 63589) [x64-mingw32]</i> to <i>ruby 2.6.0dev (2018-06-06 trunk 63593) [x64-mingw32]</i></li></ul><p>After getting frustrated with something else, I revisited this, as the errors were a test timeout errors. Followed the call stack, and found a solution to fixing the failures on mswin & mingw. I doubt it's the correct solution, but (hopefully) it will give you an idea of where the issue is...</p>
<p>See attached patch.</p>
<p>Thanks, Greg</p> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724372018-06-07T14:32:06ZMSP-Greg (Greg L)
<ul></ul><p>See GitHub PR 1883. <a href="https://github.com/ruby/ruby/pull/1883" class="external">https://github.com/ruby/ruby/pull/1883</a></p>
<p>Passed. Patch attached - GitHub_PR_1883.patch.</p>
<p>Thanks, Greg</p> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724392018-06-07T15:00:42ZMSP-Greg (Greg L)
<ul><li><strong>File</strong> <a href="/attachments/7197">GitHub_PR_1883.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/7197/GitHub_PR_1883.patch">GitHub_PR_1883.patch</a> added</li></ul> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724412018-06-07T23:48:14ZMSP-Greg (Greg L)
<ul></ul><p>Earlier today, I pushed a patch file equivalent to GitHub _PR_1883.patch to ruby-loco, and the build for</p>
<p>ruby 2.6.0dev (2018-06-07 trunk 63604) [x64-mingw32] was successful.</p>
<p>Hence, the patch works for Travis, Appveyor mswin, and Appveyor MinGW. The test runs on all platforms.</p> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724482018-06-08T14:53:51ZMSP-Greg (Greg L)
<ul></ul><p><a class="user active user-mention" href="https://bugs.ruby-lang.org/users/5">@naruse (Yui NARUSE)</a> <a class="user active user-mention" href="https://bugs.ruby-lang.org/users/9">@usa (Usaku NAKAMURA)</a></p>
<p>Thank you for the work on net/http and write_timeout. Obviously, write_nonblock works differently on Windows and *nix.</p>
<p>I'm by no means an expert on what expected behavior is with net/http, but I think it would certainly be helpful to have the write_timeout tests not skipped on windows.</p>
<p>For one thing, if windows behavior changes in the future, hopefully the test would fail...</p>
<p>Otherwise, feel free to close. Greg</p> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724502018-06-08T16:32:29Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r63613.</p>
<hr>
<p>assert_raise(Net::ReadTimeout) on Windows [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP' (Closed)" href="https://bugs.ruby-lang.org/issues/14829">#14829</a>]</p>
<p>From: MSP-Greg <a href="mailto:MSP-Greg@users.noreply.github.com" class="email">MSP-Greg@users.noreply.github.com</a></p> Ruby master - Bug #14829: test-all - 2 fails - 63589 - Windows - part of 'Introduce write_timeout to Net::HTTP'https://bugs.ruby-lang.org/issues/14829?journal_id=724512018-06-08T17:09:02Znaruse (Yui NARUSE)naruse@airemix.jp
<ul></ul><p>Sounds reasonable, I merged your patch, thanks!</p>