https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112018-06-28T14:12:44ZRuby Issue Tracking SystemRuby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=726892018-06-28T14:12:44Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:Greg.mpls@gmail.com" class="email">Greg.mpls@gmail.com</a> wrote:</p>
<blockquote>
<p>verconf.h updated<br>
../ruby/tool/transform_mjit_header.rb:118:in <code>block in check_code!': undefined method </code>success?' for nil:NilClass (NoMethodError)</p>
</blockquote>
<p>Sorry for the delay. Do you SIGCHLD on that platform?</p>
<p>"pp Signal.list" should show it</p>
<p>I'm not seeing where it's failing to call rb_last_status_set<br>
from rb_waitpid based on recent changes...<br>
(but I had a long and tiring day dealing with stuff offline<br>
and I'm running on fumes at this point)</p> Ruby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=726902018-06-28T14:25:18ZMSP-Greg (Greg L)
<ul></ul><p><a class="user active user-mention" href="https://bugs.ruby-lang.org/users/724">@normalperson (Eric Wong)</a></p>
<p>Do you SIGCHLD on that platform?</p>
<p>Really, not sure. But, I don't believe so. For instance, Puma describes using signaling for server control, and I think all the tests dealing with it are bypassed for windows. I'm really *nix challenged. One of these days...</p>
<pre><code>PS C:\Greg\GitHub> ruby -e "pp Signal.list"
{"EXIT"=>0,
"INT"=>2,
"ILL"=>4,
"ABRT"=>22,
"FPE"=>8,
"KILL"=>9,
"SEGV"=>11,
"TERM"=>15}
</code></pre>
<p>Thanks, Greg</p> Ruby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=726972018-06-29T02:22:59Znormalperson (Eric Wong)normalperson@yhbt.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r63785.</p>
<hr>
<p>process.c: fix typo in non-SIGCHLD waitpid :x</p>
<p>I expect this to fix [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Compile failure - MinGW build as of 63768 (Closed)" href="https://bugs.ruby-lang.org/issues/14873">#14873</a>]</p> Ruby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=727002018-06-29T04:55:44Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul></ul><p>Eric, your recent changes about process.c actually broke Windows build.<br>
r63785 fixed a little, but test-all still reports 14904E.<br>
I recommend to revert all commits from r63754, and restart.</p> Ruby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=727112018-06-29T11:42:37Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:usa@garbagecollect.jp" class="email">usa@garbagecollect.jp</a> wrote:</p>
<blockquote>
<p>Eric, your recent changes about process.c actually broke Windows build.<br>
r63785 fixed a little, but test-all still reports 14904E.<br>
I recommend to revert all commits from r63754, and restart.</p>
</blockquote>
<p>Can you try r63790? (Cc: you directly since ruby-core seems very slow)</p> Ruby master - Bug #14873: Compile failure - MinGW build as of 63768https://bugs.ruby-lang.org/issues/14873?journal_id=727122018-06-29T12:12:48Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul></ul><p>Hi, Eric</p>
<p>r63790 seems almost OK.<br>
Thx!!</p>
<p>--<br>
<a href="mailto:usa@garbagecollect.jp" class="email">usa@garbagecollect.jp</a></p>