https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112018-12-05T18:57:29ZRuby Issue Tracking SystemRuby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754302018-12-05T18:57:29Znormalperson (Eric Wong)normalperson@yhbt.net
<ul><li><strong>Backport</strong> changed from <i>2.4: UNKNOWN, 2.5: UNKNOWN</i> to <i>2.4: UNKNOWN, 2.5: REQUIRED</i></li></ul> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754312018-12-05T18:58:49Znormalperson (Eric Wong)normalperson@yhbt.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r66230.</p>
<hr>
<p>thread_sync.c (mutex_ptr): handle mutexes held by parent threads in children</p>
<p>Mutexes may be held by threads which only exist in the parent<br>
process, so their waitqueues may be populated with references<br>
to other dead threads. We must reset them at fork.</p>
<p>I am a moron for introducing this bug :<</p>
<p><a href="/issues/15383">[ruby-core:90312]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLED (Closed)" href="https://bugs.ruby-lang.org/issues/15383">#15383</a>]</p> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754322018-12-05T19:03:59Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><blockquote>
<p><a href="https://bugs.ruby-lang.org/issues/15383" class="external">https://bugs.ruby-lang.org/issues/15383</a></p>
</blockquote>
<p>Thanks, it affects trunk; just more difficult to reproduce<br>
because of thread cache.</p>
<p>I'm a moron for not noticing this when I fixed other bugs :<</p>
<p>r66230 should fix it in trunk and should be backported<br>
(but r66229 is independently broken and I just reverted it for now)</p> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754332018-12-05T19:36:43Zmbjs (Markus Schirp)
<ul><li><strong>Subject</strong> changed from <i>Reproducible crash: crash.sh:6: [BUG] unexpected THREAD_KILLED</i> to <i>Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLED</i></li></ul> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754342018-12-05T19:37:48Zmbjs (Markus Schirp)
<ul></ul><p>Thanks for the quick fix. Also for marking the fix to be backported.</p>
<p>Just curious, is there an associated CI build for these changes?</p> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754362018-12-05T20:22:49Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:mbj@schirp-dso.com" class="email">mbj@schirp-dso.com</a> wrote:</p>
<blockquote>
<p>Just curious, is there an associated CI build for these changes?</p>
</blockquote>
<p>I check <a href="https://rubyci.org/" class="external">https://rubyci.org/</a> and <a href="http://ci.rvm.jp/" class="external">http://ci.rvm.jp/</a> (and get<br>
automated mails from the latter).</p>
<p>There's also TravisCI; but I don't use JavaScript; so I rely<br>
on others giving me URLs to the raw logs.</p> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=754402018-12-06T00:10:43Znagachika (Tomoyuki Chikanaga)nagachika00@gmail.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/14634">Bug #14634</a>: Queue#push seems to crash after fork</i> added</li></ul> Ruby master - Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLEDhttps://bugs.ruby-lang.org/issues/15383?journal_id=757992018-12-20T08:42:48Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><blockquote>
<blockquote>
<p><a href="https://bugs.ruby-lang.org/issues/15383" class="external">https://bugs.ruby-lang.org/issues/15383</a></p>
</blockquote>
</blockquote>
<blockquote>
<p>r66230 should fix it in trunk and should be backported</p>
</blockquote>
<p>No, actually. r66230 hides an existing problem in the fix<br>
for <a href="https://bugs.ruby-lang.org/issues/14578" class="external">https://bugs.ruby-lang.org/issues/14578</a><br>
...<br>
Still working on this and my head hurts :<</p>