https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112019-02-15T01:43:27ZRuby Issue Tracking SystemRuby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768132019-02-15T01:43:27Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>There are five open pull requests relating to JRuby: <a href="https://github.com/flori/json/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+jruby" class="external">https://github.com/flori/json/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+jruby</a></p>
<p>There are 26 open pull requests in total.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768142019-02-15T01:45:48Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>I want to be clear that we are very thankful for the work that flori has put in over the years. I understand people don't always have time to work on OSS, or move on to other things, but this is a critical, core Ruby standard library...we need to be able to spin versions much more frequently.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768152019-02-15T03:06:06Zheadius (Charles Nutter)headius@headius.com
<ul><li><strong>Subject</strong> changed from <i>json library needs a more responsive maintainer</i> to <i>json library needs more frequent releases</i></li></ul> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768282019-02-15T11:35:05Zshevegen (Robert A. Heiler)shevegen@gmail.com
<ul></ul><p>I think this can be "abstracted" out in the sense of a general mechanism in place when<br>
it comes to gems that are part of the official ruby distribution, and maintainers that<br>
become inactive or at the least less active.</p>
<p>In particular when it comes to pull requests, aka code that already exists but is<br>
not merged in, I agree completely with Charles. (Let's assume here that these<br>
changes all work fine, without breaking stuff, just to simplify the argument.)</p>
<p>Perhaps a better general solution may be to allow the ruby main team to decide<br>
who is co-owner of gems IF these gems are part of the official ruby distribution.<br>
That way e. g. Charles or other folks (decided by core devs) could at the least<br>
add in the patches. Alternatively things could always be forked anyway and then<br>
merged in.</p>
<p>Since Charles mention it ("find a way to get them push rights"), what would be a<br>
simple way to get others into the position to have push rights? Could that work<br>
on rubygems/gems + rubygems.org alone or does this have to include github-hosted<br>
code? For the latter it may be feasible to have it all under the main ruby<br>
site on github. (Ideally of course, everything could be managed in-ruby, without<br>
having to depend on any external source, but I also understand that github made<br>
some feature/access simpler.)</p>
<p>IMO this may be something for the next developer meeting - this can happen to<br>
other gems too, so it seems more general to me.</p>
<p>Edit: May fit better into "Misc" than "Bugs" per se, but it's not really that<br>
important in which category it is.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768412019-02-17T01:08:38Znaruse (Yui NARUSE)naruse@airemix.jp
<ul></ul><p>You may know hsbt and I get write access to repo recently.<br>
So for those JRuby issues, you can ask us to merge after you review it.<br>
And also you can push gem, we can handle fix an issue and push a gem if there's a emergency.</p>
<p>Anyway we also worried about json.gem..</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768432019-02-17T11:18:01ZEregon (Benoit Daloze)
<ul></ul><p>Would it make sense to move the repository under the ruby organization, since it is a default gem maintained by ruby-core now?</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=768642019-02-21T15:28:48Zheadius (Charles Nutter)headius@headius.com
<ul></ul><blockquote>
<p>Perhaps a better general solution may be to allow the ruby main team to decide who is co-owner of gems IF these gems are part of the official ruby distribution.</p>
</blockquote>
<p>This seems like a good rule of thumb. I know we've had trouble finding maintainers for some libraries, but anything that lives as an external gem should have at least two maintainers always in case one gets pulled away. The json gem has for too long had only the one maintainer, other than partial support from JRuby team for our version of the extension.</p>
<blockquote>
<p>You may know hsbt and I get write access to repo recently.</p>
</blockquote>
<p>That's great! We'll ping you from the relevant PRs we need merged and we can talk about a release.</p>
<p>I'm not sure whether I can (or should) add naruse or hsbt as a gem pusher...but I think we need someone (other than flori) from the C side to also be able to push the gem when there's fixes.</p>
<blockquote>
<p>Would it make sense to move the repository under the ruby organization, since it is a default gem maintained by ruby-core now?</p>
</blockquote>
<p>I think it would be worthwhile to do this for every gem that's included as part of stdlib. The racc library has similar issues, not because of unresponsive maintainers but because nobody really wants to own it anymore. I've been trying to get some fixes in there and released too (working with tenderlove on and off this month to do that).</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=770822019-03-13T13:21:19Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>FWIW we did just get a json 2.2.0 release. The base problem stands, however.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=785002019-06-12T23:43:25Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Misc</i></li><li><strong>ruby -v</strong> deleted (<del><i>all</i></del>)</li><li><strong>Backport</strong> deleted (<del><i>2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN</i></del>)</li></ul> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=828112019-11-27T11:43:45Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Tracker</strong> changed from <i>Misc</i> to <i>Feature</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>hsbt (Hiroshi SHIBATA)</i></li></ul><p>I submit the backport changes from ruby core to flori/json at <a href="https://github.com/flori/json/pull/388" class="external">https://github.com/flori/json/pull/388</a></p>
<p>We need to bump version to ruby repository like 2.2.1 because the same version of flori/json and ruby core confuse ruby users.</p>
<p>I hope to merge the above pull request, bump version and cut off a new release by flori. When there is no response from flori, We should release 2.2.1 ourselves.</p>
<p><a class="user active user-mention" href="https://bugs.ruby-lang.org/users/286">@headius (Charles Nutter)</a> Can you help me for pushing json gem?</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=830512019-12-09T21:18:38Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>I can build and push the json gem for JRuby any time. I'm on the ruby-lang slack today, just tell me what repo/branch needs to be pushed out!</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=833462019-12-23T11:15:33Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>naruse did release json-2.3.0 from the current master branch of ruby/ruby.</p>
<p>We will handle the new feature of JSON with ruby/ruby repo in the future.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=833502019-12-23T12:56:09ZEregon (Benoit Daloze)
<ul></ul><p>hsbt (Hiroshi SHIBATA) wrote:</p>
<blockquote>
<p>We will handle the new feature of JSON with ruby/ruby repo in the future.</p>
</blockquote>
<p>I'm not sure what you mean, could you clarify?</p>
<p>Is it that releases of the json gem will be done from the ruby/ruby repository?</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=833762019-12-24T06:56:53Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul></ul><blockquote>
<p>s it that releases of the json gem will be done from the ruby/ruby repository?</p>
</blockquote>
<p>No. We can merge commits from ruby/ruby to flori/json and release it.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=844112020-02-27T10:49:39Zbyroot (Jean Boussier)byroot@ruby-lang.org
<ul></ul><p>What's the status on this ?</p>
<p>I understand that a part of the gem is now edited from ruby/ruby, but that exclude the <code>pure</code> and <code>java</code> implementations. So this doesn't sounds like a good long term solution, and more like a temporary workaround.</p>
<p>If the gem needs new maintainers, I'm confident that it can be solved (I and other folks at Shopify can surely step in), but it first require a clarification on the repo and gem ownership.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=844732020-03-03T20:04:14ZEregon (Benoit Daloze)
<ul></ul><p>I tried to make a step in that direction 2 weeks ago in <a href="https://github.com/flori/json/pull/402#issuecomment-586585888" class="external">https://github.com/flori/json/pull/402#issuecomment-586585888</a><br>
But no answer yet from flori (even on such a trivial PR).</p>
<p>The current maintainer doesn't answer frequently enough for such an important part of the stdlib, I believe we need additional maintainers.</p> Ruby master - Feature #15605: json library needs more frequent releaseshttps://bugs.ruby-lang.org/issues/15605?journal_id=844742020-03-03T20:17:10Zbyroot (Jean Boussier)byroot@ruby-lang.org
<ul></ul><blockquote>
<p>I tried to make a step in that direction 2 weeks ago</p>
</blockquote>
<p>Thanks for the link, I had no idea. I suppose I'll subscribe there and wait.</p>