https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112019-12-22T06:12:27ZRuby Issue Tracking SystemRuby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833262019-12-22T06:12:27Zshevegen (Robert A. Heiler)shevegen@gmail.com
<ul></ul><p>Agreed for compatibility - may be better to retain the old behaviour as-is.</p>
<p>I believe it was not a deliberate change but an oversight since the author<br>
of reline here on the issue tracker also mentioned compatibility being<br>
an important goal for the rewrite, about a year ago; matz also mentioned<br>
this.</p>
<p>Hopefully that may be fixed before xmas. :)</p> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833272019-12-22T07:16:38Zy-yagi (Yuji Yaginuma)
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/83327/diff?detail_id=55895">diff</a>)</li></ul> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833282019-12-22T08:07:28Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>I believe that it is too late to discuss "opt-in or opt-out?".</p>
<p>IMO, the quality of the new IRB is not so low. But it highly depends upon environments (OS, terminal, how to use, etc.), so we want people to use the new version, give feedback, and help us improve quality. That being said, if people hit an issue, they need to work around it. So the banner message is added.</p>
<p>I understand that the message is not fit to rails console. But "change the default!" and "remove the message!" are too aggressive, I think. Please consider why it is added, and please propose more moderate options like rephasing the message, providing another way to configure it, etc.</p> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833312019-12-22T11:02:48Zy-yagi (Yuji Yaginuma)
<ul></ul><p>Thanks for your feedback. OK. I understood that too late to discuss and a message is as expected.</p>
<p>I think it would be good if the message could be configurable, but I will also consider expanding the options on the library side. Thanks.</p> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833342019-12-22T14:03:03Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>I guess we may provide an API to hide or alter the message for rails console and other tools. Pull request is welcome to ruby/irb.</p> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833352019-12-22T16:10:01Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>A patch to suppress the warning when started as <code>console</code>.</p>
<pre><code class="diff syntaxhl" data-language="diff"><span class="gh">diff --git a/lib/irb/init.rb b/lib/irb/init.rb
index 2af872fd03..464b33ae03 100644
</span><span class="gd">--- a/lib/irb/init.rb
</span><span class="gi">+++ b/lib/irb/init.rb
</span><span class="p">@@ -31,6 +31,8 @@</span>
@TRACER_INITIALIZED = false
# default configurations
<span class="gi">+ @CONF[:USE_MULTILINE] = true if ap_path
+
</span> unless ap_path and @CONF[:AP_NAME]
ap_path = File.join(File.dirname(File.dirname(__FILE__)), "irb.rb")
end
</code></pre> Ruby master - Misc #16444: What is the reason for the warning of IRB? https://bugs.ruby-lang.org/issues/16444?journal_id=833682019-12-24T01:17:17Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>The IRB maintainer <a class="user active user-mention" href="https://bugs.ruby-lang.org/users/11389">@aycabta (aycabta .)</a> has determined to remove the message. <a href="https://github.com/ruby/ruby/commit/0e528ae9cb5c1078e4d07287e403cb548e97f0a3" class="external">https://github.com/ruby/ruby/commit/0e528ae9cb5c1078e4d07287e403cb548e97f0a3</a></p>