https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112009-07-24T01:11:18ZRuby Issue Tracking SystemRuby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=49412009-07-24T01:11:18Zdjberg96 (Daniel Berger)
<ul></ul><p>=begin<br>
I agree, although I'd favor getting rid of the 'do_' and just make it Socket.reverse_lookup=</p>
<p>Regards,</p>
<p>Dan<br>
=end</p> Ruby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=49432009-07-24T02:55:12Zwyhaines (Kirk Haines)wyhaines@gmail.com
<ul></ul><p>=begin<br>
This seems completely reasonable to me. Most serious networking code<br>
is going to disable the reverse DNS lookups anyway, so Ruby may as<br>
well default to the option most code is going to want.</p>
<p>Kirk Haines</p>
<p>=end</p> Ruby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=61492009-10-10T01:00:13Zrogerdpack (Roger Pack)rogerpack2005@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/571">do_not_reverse_lookup.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/571/do_not_reverse_lookup.diff">do_not_reverse_lookup.diff</a> added</li></ul><p>=begin<br>
Here's a patch that does it. None of the documentation seems to mention that it defaults to true, so this should be enough for now.<br>
Socket doesn't appears to have a maintainer [1] so anybody want to?<br>
Thanks.<br>
-r<br>
[1] <a href="http://redmine.ruby-lang.org/wiki/ruby/Maintainers" class="external">http://redmine.ruby-lang.org/wiki/ruby/Maintainers</a><br>
=end</p> Ruby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=61512009-10-10T03:18:59Zrogerdpack (Roger Pack)rogerpack2005@gmail.com
<ul></ul><p>=begin<br>
Interestingly, when I apply this patch, then run make test-all, two tests that previously broke:</p>
<ol start="2">
<li>
<p>Error:<br>
test_cookie(TestCookie):<br>
NoMethodError: undefined method <code>shutdown' for nil:NilClass /home/rdp/dev/downloads/ruby_trunk/test/xmlrpc/webrick_testing.rb:32:in </code>block in stop_server'</p>
</li>
<li>
<p>Error:<br>
test_client_server(Test_Webrick):<br>
NoMethodError: undefined method <code>shutdown' for nil:NilClass /home/rdp/dev/downloads/ruby_trunk/test/xmlrpc/webrick_testing.rb:32:in </code>block in stop_server'</p>
</li>
</ol>
<p>Now succeed happily--appears that there's a timing issue where the setup thread is not completing early enough because it is blocked doing DNS lookups :)</p>
<p>Thanks.<br>
-r<br>
=end</p> Ruby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=70892009-12-01T19:17:45Zujihisa (Tatsuhiro Ujihisa)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>nobu (Nobuyoshi Nakada)</i></li></ul><p>=begin</p>
<p>=end</p> Ruby master - Feature #1811: Default BasicSocket.do_not_reverse_lookup to truehttps://bugs.ruby-lang.org/issues/1811?journal_id=81062010-02-02T18:17:05Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
This issue was solved with changeset r26541.<br>
Roger, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<p>=end</p>