https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112009-07-31T02:41:39ZRuby Issue Tracking SystemRuby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=50122009-07-31T02:41:39Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul></ul><p>=begin<br>
My impression is that such symbols should be forbidden to exist.<br>
=end</p> Ruby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=66762009-11-04T22:50:00Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Category</strong> set to <i>core</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>matz (Yukihiro Matsumoto)</i></li></ul><p>=begin<br>
I agree with shyouhei.<br>
=end</p> Ruby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=84942010-03-01T23:57:24Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi,</p>
<p>Brian Candler wrote:</p>
<blockquote>
<p>However Symbol#inspect raises an exception if it was made from a string with an invalid encoding.</p>
</blockquote>
<p>Shyouhei Urabe wrote:</p>
<blockquote>
<p>My impression is that such symbols should be forbidden to exist.</p>
</blockquote>
<p>Yui NARUSE wrote:</p>
<blockquote>
<p>I agree with shyouhei.</p>
</blockquote>
<p>I guess we have already agreed the conclusion. Must we wait for matz?</p>
<p>diff --git a/parse.y b/parse.y<br>
index e338c6f..6a0e431 100644<br>
--- a/parse.y<br>
+++ b/parse.y<br>
@@ -9505,6 +9505,10 @@ rb_intern3(const char *name, long len, rb_encoding *enc)<br>
str = (VALUE)&fake_str;<br>
rb_enc_associate(str, enc);</p>
<ul>
<li>if (rb_enc_str_coderange(str) == ENC_CODERANGE_BROKEN) {</li>
<li>
<pre><code> rb_raise(rb_eEncodingError, "invalid encoding symbol");
</code></pre>
</li>
<li>}</li>
<li>if (st_lookup(global_symbols.sym_id, str, (st_data_t *)&id))<br>
return id;</li>
</ul>
<p>diff --git a/test/ruby/test_m17n_comb.rb b/test/ruby/test_m17n_comb.rb<br>
index ab89136..cf80377 100644<br>
--- a/test/ruby/test_m17n_comb.rb<br>
+++ b/test/ruby/test_m17n_comb.rb<br>
@@ -1040,10 +1040,12 @@ class TestM17NComb < Test::Unit::TestCase<br>
STRINGS.each {|s|<br>
if /\0/ =~ a(s)<br>
assert_raise(ArgumentError) { s.intern }</p>
<ul>
<li>
<pre><code> else
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> elsif s.valid_encoding?
sym = s.intern
assert_equal(s, sym.to_s, "#{encdump s}.intern.to_s")
assert_equal(sym, s.to_sym)
</code></pre>
</li>
<li>
<pre><code> else
</code></pre>
</li>
<li>
<pre><code> assert_raise(EncodingError) { s.intern }
end
</code></pre>
}<br>
end</li>
</ul>
<p>--<br>
Yusuke ENDOH <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p> Ruby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=90112010-03-16T17:48:46Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p>=begin<br>
Hi,</p>
<p>In message "Re: <a href="https://blade.ruby-lang.org/ruby-core/28384">[ruby-core:28384]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Symbol#inspect raises exception (Closed)" href="https://bugs.ruby-lang.org/issues/1843">#1843</a>] Symbol#inspect raises exception"<br>
on Mon, 1 Mar 2010 23:58:47 +0900, Yusuke Endoh <a href="mailto:redmine@ruby-lang.org" class="email">redmine@ruby-lang.org</a> writes:</p>
<p>|Brian Candler wrote:<br>
|> However Symbol#inspect raises an exception if it was made from a string with an invalid encoding.<br>
|<br>
|Shyouhei Urabe wrote:<br>
|> My impression is that such symbols should be forbidden to exist.<br>
|<br>
|Yui NARUSE wrote:<br>
|> I agree with shyouhei.<br>
|<br>
|I guess we have already agreed the conclusion. Must we wait for matz?</p>
<p>OK, OK. Go ahead and check it in.</p>
<pre><code> matz.
</code></pre>
<p>=end</p> Ruby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=90162010-03-17T01:27:05Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
This issue was solved with changeset r26957.<br>
Brian, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<p>=end</p> Ruby master - Bug #1843: Symbol#inspect raises exceptionhttps://bugs.ruby-lang.org/issues/1843?journal_id=90192010-03-17T02:51:04Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>=begin<br>
2010/3/16 Yukihiro Matsumoto <a href="mailto:matz@ruby-lang.org" class="email">matz@ruby-lang.org</a>:</p>
<blockquote>
<p>OK, OK. Go ahead and check it in.</p>
</blockquote>
<p>Done. Thanks!</p>
<p>--<br>
Yusuke ENDOH <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p>
<p>=end</p>