https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112022-01-17T13:53:48ZRuby Issue Tracking SystemRuby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=960232022-01-17T13:53:48Zmdalessio (Mike Dalessio)mike.dalessio@gmail.com
<ul></ul><p>Pinging <a class="user active user-mention" href="https://bugs.ruby-lang.org/users/4">@nobu (Nobuyoshi Nakada)</a> for feedback as he is the primary maintainer of mkmf</p> Ruby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=960332022-01-18T04:38:42Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>Thank you for the report and patch.<br>
It seems fine.<br>
Could you split adding tests of existing methods from the new feature?</p> Ruby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=960372022-01-18T14:50:49Zmdalessio (Mike Dalessio)mike.dalessio@gmail.com
<ul></ul><p>Thank you for taking the time to review. I've split the commit as you requested:</p>
<p><a href="https://github.com/ruby/ruby/pull/5436/commits" class="external">https://github.com/ruby/ruby/pull/5436/commits</a></p> Ruby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=961352022-01-25T02:15:40Zmdalessio (Mike Dalessio)mike.dalessio@gmail.com
<ul></ul><p><a class="user active user-mention" href="https://bugs.ruby-lang.org/users/4">@nobu (Nobuyoshi Nakada)</a>, I wanted to check if there was any other feedback on this feature? Thank you again for your time.</p> Ruby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=962332022-01-29T03:01:10Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul><li><strong>Assignee</strong> set to <i>nobu (Nobuyoshi Nakada)</i></li></ul><p>Accepted.</p>
<p>Matz.</p> Ruby master - Feature #18490: MakeMakefile.pkg_config should accept multiple optionshttps://bugs.ruby-lang.org/issues/18490?journal_id=964982022-02-15T07:30:12Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul>