https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112022-05-20T17:06:59ZRuby Issue Tracking SystemRuby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=976872022-05-20T17:06:59Zmdalessio (Mike Dalessio)mike.dalessio@gmail.com
<ul></ul><p>After working through this in <a href="https://github.com/sparklemotion/nokogiri/pull/2532#issuecomment-1121302762" class="external">https://github.com/sparklemotion/nokogiri/pull/2532#issuecomment-1121302762</a> I agree that Ruby should provide an easier mechanism for discovering whether compaction is supported.</p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=977022022-05-23T22:54:57Zmdalessio (Mike Dalessio)mike.dalessio@gmail.com
<ul></ul><p>I've submitted a pull request that addresses this behavior in the way <a class="user active user-mention" href="https://bugs.ruby-lang.org/users/7941">@byroot (Jean Boussier)</a> described above:</p>
<p><a href="https://github.com/ruby/ruby/pull/5934" class="external">https://github.com/ruby/ruby/pull/5934</a></p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=977092022-05-24T17:05:22Zbyroot (Jean Boussier)byroot@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Backport</strong> changed from <i>2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN</i> to <i>2.7: WONTFIX, 3.0: REQUIRED, 3.1: REQUIRED</i></li></ul><p>The PR was merged so we can now close this.</p>
<p>I'm marking 3.0 and 3.1 for backport. The two commits are:</p>
<ul>
<li><code>0de1495f358e9b892dfa63d4b74f59b1d2903703</code></li>
<li><code>0c36ba53192c5a0d245c9b626e4346a32d7d144e</code></li>
</ul> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=977532022-05-25T20:00:29ZEregon (Benoit Daloze)
<ul><li><strong>Is duplicate of</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/18560">Bug #18560</a>: "Compaction isn't available on this platform" error running PG test suite on ppc64le</i> added</li></ul> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=978022022-05-31T09:59:23Zjaruga (Jun Aruga)
<ul></ul><blockquote>
<p>I'm marking 3.0 and 3.1 for backport. The two commits are:</p>
<p>6ddec1082d06431111123c03b18ca41e7a2cec12<br>
e9623f7432b4603735c74b6f0bb683a9bf19c2c6</p>
</blockquote>
<p>Did you backport to ruby_3_0 and ruby_3_1 branches? I cannot find the 2 commit hashes above.</p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=978032022-05-31T10:01:46Zbyroot (Jean Boussier)byroot@ruby-lang.org
<ul></ul><p><a class="user active user-mention" href="https://bugs.ruby-lang.org/users/11018">@jaruga (Jun Aruga)</a> no, I requested it, but it's the release manager of each branch that is supposed to do the backport.</p>
<p>These two commits are on master. The backported commits will likely be widely different as there was many changes in compaction APIs between 3.0 and master.</p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=978042022-05-31T10:26:30Zjaruga (Jun Aruga)
<ul></ul><blockquote>
<p>no, I requested it, but it's the release manager of each branch that is supposed to do the backport.</p>
</blockquote>
<p>Sorry for my mistake. The "3.0: REQUIRED, 3.1: REQUIRED" (not DONE) shows the statuses clearly.</p>
<blockquote>
<p>These two commits are on master. The backported commits will likely be widely different as there was many changes in compaction APIs between 3.0 and master.</p>
</blockquote>
<p>I see. How about changes between 3.1 and master? Many changes? I want to see the backport at least on Ruby 3.1.</p>
<p>Ah I found the 2 commits you shared on the PR below. But the commits were rebased on the master. That's why I could not find those on the master.<br>
<a href="https://github.com/ruby/ruby/pull/5934/commits" class="external">https://github.com/ruby/ruby/pull/5934/commits</a></p>
<p>I think the 2 commits on the master are below.<br>
<a href="https://github.com/ruby/ruby/commit/0de1495f358e9b892dfa63d4b74f59b1d2903703" class="external">https://github.com/ruby/ruby/commit/0de1495f358e9b892dfa63d4b74f59b1d2903703</a><br>
<a href="https://github.com/ruby/ruby/commit/0c36ba53192c5a0d245c9b626e4346a32d7d144e" class="external">https://github.com/ruby/ruby/commit/0c36ba53192c5a0d245c9b626e4346a32d7d144e</a></p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=978052022-05-31T10:30:07Zbyroot (Jean Boussier)byroot@ruby-lang.org
<ul></ul><p>Indeed, thank you.</p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=1003542022-11-30T13:39:47Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul></ul><p>If it helps, this <a href="https://src.fedoraproject.org/rpms/ruby/blob/9819174c8dd5a04f7cc47d50d586cc6f72b8f0b7/f/ruby-3.2.0-define-unsupported-gc-compaction-methods-as-rb_f_notimplement.patch" class="external">1</a> is the patch we are carrying around in Fedora for Ruby 3.1. I would appreciate if is backported, because it influences files which are pregenerated and part of the release tarball <a href="https://src.fedoraproject.org/rpms/ruby/blob/9819174c8dd5a04f7cc47d50d586cc6f72b8f0b7/f/ruby-3.2.0-define-unsupported-gc-compaction-methods_generated-files.patch" class="external">2</a>.</p> Ruby master - Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779?journal_id=1025402023-03-25T01:55:59Znagachika (Tomoyuki Chikanaga)nagachika00@gmail.com
<ul></ul><p>MEMO: It seems that <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: GC_COMPACTION_SUPPORTED macro should be set and detected automatically. (Closed)" href="https://bugs.ruby-lang.org/issues/18829">#18829</a> is required to be backported preceded for this issue.</p>