Backport #2261

lib/matrix: following the extensive changes

Added by marcandre (Marc-Andre Lafortune) almost 11 years ago. Updated over 9 years ago.



(a) Shouldn't r25412 (and other related commits) be also applied to the 1.8 branch?

(b) r25412 introduced Matrix#inspect_org. It is not documented.

Its output relies on the way the matrix information is stored internally by the Matrix class. Shouldn't this be considered implementation details and thus subject to change and not for public consumption?

It should either:

  • be removed,
  • be made private (although it is not used by the implementation) or
  • be documented

I recommend the first option

(c) #compare_by_row_vectors and #compare_by should either:

  • be removed (they are not used by the implementation anymore),
  • be made private or
  • be documented.

I recommend the first option


Updated by marcandre (Marc-Andre Lafortune) over 10 years ago

  • Assignee changed from keiju (Keiju Ishitsuka) to marcandre (Marc-Andre Lafortune)




Updated by marcandre (Marc-Andre Lafortune) about 10 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r28168.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Also available in: Atom PDF