Feature #2561

1.8.7 Patch reduces time cost of Rational operations by 50%.

Added by Kurt Stephens over 4 years ago. Updated almost 3 years ago.

[ruby-core:27437]
Status:Closed
Priority:Normal
Assignee:Akinori MUSHA
Category:-
Target version:-

Description

=begin
This changes adds a specialize Fixnum#gcd and a tuned rational.rb.

Reduced overall time on Rational operations by > 50%.

user system total real
testit 22.380000 2.140000 24.520000 ( 24.559388)
test
it ksrational 17.870000 1.830000 19.700000 ( 19.687221)
test
it ks_rational + Fixnum#gcd 10.660000 0.000000 10.660000 ( 10.665765)

The patch will perform better with Fixnum#gcd on numeric.c but still is faster with only the rational.rb changes.

I have a version for 1.8.6 if someone wants it.
=end

rational_performance.rb Magnifier (1.85 KB) Kurt Stephens, 01/06/2010 10:58 AM

ruby-1.8.7-rational.patch Magnifier (9.1 KB) Kurt Stephens, 01/06/2010 10:58 AM

rational_performance.rb Magnifier (2.29 KB) Kurt Stephens, 01/07/2010 03:43 AM

ruby-1.8.7-rational.patch Magnifier (9.39 KB) Kurt Stephens, 01/07/2010 03:43 AM

ruby-1.8.7-rational.patch Magnifier - Fixed Fixnum#gcd for FIXNUM_MIN. (10.7 KB) Kurt Stephens, 01/12/2010 01:18 AM

gcd_test.rb Magnifier (21.6 KB) Kurt Stephens, 01/12/2010 01:18 AM

gcd_test.rb Magnifier - 64-bit test cases. (44.6 KB) Kurt Stephens, 01/22/2010 05:58 AM

ruby-1.8.7-fixnum_gcd.patch Magnifier - numeric.c patch. (1.28 KB) Kurt Stephens, 01/22/2010 05:58 AM


Related issues

Duplicated by Ruby 1.8 - Backport #838: faster gcd for 187 Closed 12/08/2008

Associated revisions

Revision 26581
Added by Akinori MUSHA about 4 years ago

  • ext/rational/rational.c: Added to provide a fast implementation
    of Fixnum#gcd (and maybe some others in the future) in C. The
    base code was submitted by Kurt Stephens. [Feature #2561]

  • ext/rational/lib/rational.rb: Moved from lib/rational.rb. Make
    overall code optimization; submitted by Kurt Stephens.
    [Feature #2561]

  • test/rational/testrational.rb, test/rational/testrational2.rb:
    Add tests for Rational, ported from trunk.

  • test/rational/testfixnumgcd.rb: Add a test for Integer#gcd.
    Case values are only provided for i386 and amd64 at the moment;
    submitted by Kurt Stephens. [Feature #2561]

History

#1 Updated by Yui NARUSE over 4 years ago

  • Status changed from Open to Assigned
  • Assignee set to Akinori MUSHA

=begin
Discuss in Ruby 1.8 first,
=end

#2 Updated by Kurt Stephens over 4 years ago

=begin
New version:

Avoid additional method calls to Float(), call #to_f directly. Avoid Rational() when its clear that denominator will never be 1.

=end

#3 Updated by Kurt Stephens over 4 years ago

=begin
Fixed Fixnum#gcd for FIXNUM_MIN.

Ref: http://github.com/kstephens/rubyenterpriseedition187/commit/877d5e4c7892248bb7486f24c076cb23d565a466

gcd_test.rb should pass on 32-bit builds.

=end

#4 Updated by Kurt Stephens over 4 years ago

=begin
Fixed Fixnum#gcd to FIXNUM_MIN on 64-bit longs.

Ref: http://github.com/kstephens/rubyenterpriseedition187-248/commit/4863695e774d427d95c0828f8d2d5a92a433a1c4

gcd_test.rb should pass on 64-bit builds.

=end

#5 Updated by Akinori MUSHA over 4 years ago

=begin
Patches look fine to me. I'll handle this as soon as I can take the time, hopefully within a couple weeks.

I think it's better to have the C part as extension rather than putting Fixnum#gcd solely in the core,
so I'll make some layout changes to bring this in in the best shape for future maintainability.

=end

#6 Updated by Akinori MUSHA about 4 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r26581.
Kurt , thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Also available in: Atom PDF