Project

General

Profile

Actions

Bug #3299

closed

revision.h rule in common.mk is broken for MSVC

Added by romuloceccon (Rômulo Ceccon) almost 14 years ago. Updated almost 13 years ago.

Status:
Closed
Assignee:
-
Target version:
ruby -v:
ruby 1.8.8dev [i386-mswin32_90]
[ruby-core:30249]

Description

=begin
Commit 27107 http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=27107 broke revision.h rule when trying to compile with MSVC:

'{' is not recognized as an internal or external command,
operable program or batch file.
NMAKE : warning U4004: too many rules for target './revision.h'
cl -nologo -MD -O2b2xty- -DRUBY_EXPORT -I. -I. -I./missing -D_CRT_SE
CURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE -c -Tcversion.c
version.c

That doesn't stop compilation, but revision.h is left blank and no revision information is embedded in the executable.

Attached is a patch which fixes the problem with multiple rules and moves the sed expressions to a file so that the command runs correctly on both Windows and Posix systems (currently the sed statement will not work on Windows due to improperly escaped characters).
=end


Files

ruby_27107_fix.diff (1.99 KB) ruby_27107_fix.diff Fix for broken revision.h rule in common.mk romuloceccon (Rômulo Ceccon), 05/15/2010 05:36 AM
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0