https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112010-06-24T00:32:18ZRuby Issue Tracking SystemRuby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=118972010-06-24T00:32:18Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Assignee</strong> set to <i>drbrain (Eric Hodel)</i></li></ul><p>=begin</p>
<p>=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=120622010-06-29T02:06:04Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Target version</strong> set to <i>1.9.2</i></li></ul><p>=begin<br>
Hi,</p>
<p>This issue seems to be reproducible only on windows.<br>
Unless anyone suggests any fix by today, this issue will be WONTFIX<br>
for 1.9.2.</p>
<p>This is the last ticket that is a show stopper against 1.9.2 release.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=120632010-06-29T02:14:32Zrogerdpack (Roger Pack)rogerpack2005@gmail.com
<ul></ul><p>=begin<br>
Yeah I wouldn't call this a high priority ticket.<br>
=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=120692010-06-29T20:52:40Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>=begin<br>
gem_prelude.rb:push_all_highest_version_gems_on_load_path expects gem<br>
directory names to be "#{GEMNAME}-#{VERSION}", but the native gem<br>
directory name is suffixed by the platform name.</p>
<p>The following patch may help or may not.</p>
<p><br>
diff --git a/gem_prelude.rb b/gem_prelude.rb<br>
index 71f30bd..3be64aa 100644<br>
--- a/gem_prelude.rb<br>
+++ b/gem_prelude.rb<br>
@@ -229,8 +229,12 @@ if defined?(Gem) then<br>
Dir.entries(gems_directory).each do |gem_directory_name|<br>
next if gem_directory_name == "." || gem_directory_name == ".."</p>
<ul>
<li>
<pre><code> next unless gem_name = gem_directory_name[/(.*)-(.*)/, 1]
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> next unless gem_name = gem_directory_name[/(.*)-(\d+(?:\.\d+)*)(?:-(.*))?/, 1]
new_version = integers_for($2)
</code></pre>
</li>
<li>
<pre><code> if platform = $3
</code></pre>
</li>
<li>
<pre><code> require 'rubygems/platform'
</code></pre>
</li>
<li>
<pre><code> Gem::Platform.match(platform) or next
</code></pre>
</li>
<li>
<pre><code> end
current_version = GemVersions[gem_name]
if !current_version or (current_version <=> new_version) < 0 then
</code></pre>
</li>
</ul>
<p>=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124262010-07-20T22:25:09Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Assignee</strong> changed from <i>drbrain (Eric Hodel)</i> to <i>ephoenix (Evan Phoenix)</i></li></ul><p>=begin<br>
Hi, Evan</p>
<p>This ticket is about gem_prelude.rb.<br>
Do you think this should be fixed in 1.9.2?<br>
And what do you think about nobu's patch?</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124282010-07-21T01:23:31Zevanphx (Evan Phoenix)evan@phx.io
<ul></ul><p>=begin</p>
<p>On Jul 20, 2010, at 6:25 AM, Yusuke Endoh wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: gem activation fails for native gems (Closed)" href="https://bugs.ruby-lang.org/issues/3462">#3462</a> has been updated by Yusuke Endoh.</p>
<p>Assigned to changed from Eric Hodel to Evan Phoenix</p>
<p>Hi, Evan</p>
<p>This ticket is about gem_prelude.rb.<br>
Do you think this should be fixed in 1.9.2?<br>
And what do you think about nobu's patch?</p>
</blockquote>
<p>Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.</p>
<p>If we can apply the patch to 1.9.2, we should.</p>
<ul>
<li>Evan</li>
</ul>
<blockquote>
<h2>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a>
</h2>
<p><a href="http://redmine.ruby-lang.org/issues/show/3462" class="external">http://redmine.ruby-lang.org/issues/show/3462</a></p>
<hr>
<p><a href="http://redmine.ruby-lang.org" class="external">http://redmine.ruby-lang.org</a></p>
</blockquote>
<p>=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124292010-07-21T01:32:08Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi,</p>
<p>2010/7/21 Evan Phoenix <a href="mailto:evan@fallingsnow.net" class="email">evan@fallingsnow.net</a>:</p>
<blockquote>
<blockquote>
<p>Hi, Evan</p>
<p>This ticket is about gem_prelude.rb.<br>
Do you think this should be fixed in 1.9.2?<br>
And what do you think about nobu's patch?</p>
</blockquote>
<p>Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.</p>
<p>If we can apply the patch to 1.9.2, we should.</p>
</blockquote>
<p>Thank you for your quick reply!</p>
<p>Did you get a commit bit? If you did, could you apply it to<br>
trunk and check "make test-rubyspec" and "make check"?<br>
If you see no problem, please commit it to trunk.</p>
<p>If no problem is reported in a few days, I'll backport it to<br>
ruby_1_9_2.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124302010-07-21T01:34:54Zevanphx (Evan Phoenix)evan@phx.io
<ul></ul><p>=begin</p>
<p>On Jul 20, 2010, at 9:32 AM, Yusuke Endoh wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: gem activation fails for native gems (Closed)" href="https://bugs.ruby-lang.org/issues/3462">#3462</a> has been updated by Yusuke Endoh.</p>
<p>Hi,</p>
<p>2010/7/21 Evan Phoenix <a href="mailto:evan@fallingsnow.net" class="email">evan@fallingsnow.net</a>:</p>
<blockquote>
<blockquote>
<p>Hi, Evan</p>
<p>This ticket is about gem_prelude.rb.<br>
Do you think this should be fixed in 1.9.2?<br>
And what do you think about nobu's patch?</p>
</blockquote>
<p>Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.</p>
<p>If we can apply the patch to 1.9.2, we should.</p>
</blockquote>
<p>Thank you for your quick reply!</p>
</blockquote>
<p>No problem!</p>
<blockquote>
<p>Did you get a commit bit? If you did, could you apply it to<br>
trunk and check "make test-rubyspec" and "make check"?<br>
If you see no problem, please commit it to trunk.</p>
</blockquote>
<p>Yep! I've got a commit bit now, I'll apply to trunk and commit it if it's fine.</p>
<blockquote>
<p>If no problem is reported in a few days, I'll backport it to<br>
ruby_1_9_2.</p>
</blockquote>
<p>Wonderful!</p>
<blockquote>
<h2>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a>
</h2>
<p><a href="http://redmine.ruby-lang.org/issues/show/3462" class="external">http://redmine.ruby-lang.org/issues/show/3462</a></p>
<hr>
<p><a href="http://redmine.ruby-lang.org" class="external">http://redmine.ruby-lang.org</a></p>
</blockquote>
<p>=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124312010-07-21T03:45:57Zevanphx (Evan Phoenix)evan@phx.io
<ul></ul><p>=begin<br>
I've committed a slightly revised version of the patch that nobu and I worked on into trunk. It solves the gem activation issues because it loads all of rubygems to perform any gem activation.</p>
<p>Hopefully we can have this backported to 1.9.2 soon.</p>
<p>Thanks!</p>
<ul>
<li>Evan</li>
</ul>
<p>On Jul 20, 2010, at 9:34 AM, Evan Phoenix wrote:</p>
<blockquote>
<p>On Jul 20, 2010, at 9:32 AM, Yusuke Endoh wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: gem activation fails for native gems (Closed)" href="https://bugs.ruby-lang.org/issues/3462">#3462</a> has been updated by Yusuke Endoh.</p>
<p>Hi,</p>
<p>2010/7/21 Evan Phoenix <a href="mailto:evan@fallingsnow.net" class="email">evan@fallingsnow.net</a>:</p>
<blockquote>
<blockquote>
<p>Hi, Evan</p>
<p>This ticket is about gem_prelude.rb.<br>
Do you think this should be fixed in 1.9.2?<br>
And what do you think about nobu's patch?</p>
</blockquote>
<p>Nobu's patch is fine. It's a minor modification of my original patch for this issue. Nobu's patch was reverted from trunk because of the lazy sweep issue, as I recall.</p>
<p>If we can apply the patch to 1.9.2, we should.</p>
</blockquote>
<p>Thank you for your quick reply!</p>
</blockquote>
<p>No problem!</p>
<blockquote>
<p>Did you get a commit bit? If you did, could you apply it to<br>
trunk and check "make test-rubyspec" and "make check"?<br>
If you see no problem, please commit it to trunk.</p>
</blockquote>
<p>Yep! I've got a commit bit now, I'll apply to trunk and commit it if it's fine.</p>
<blockquote>
<p>If no problem is reported in a few days, I'll backport it to<br>
ruby_1_9_2.</p>
</blockquote>
<p>Wonderful!</p>
<blockquote>
<h2>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a>
</h2>
<p><a href="http://redmine.ruby-lang.org/issues/show/3462" class="external">http://redmine.ruby-lang.org/issues/show/3462</a></p>
<hr>
<p><a href="http://redmine.ruby-lang.org" class="external">http://redmine.ruby-lang.org</a></p>
</blockquote>
</blockquote>
<p>=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=124602010-07-22T02:25:56Zrogerdpack (Roger Pack)rogerpack2005@gmail.com
<ul></ul><p>=begin<br>
Seems to work now. Since it doesn't pre-load $: with any gem lib paths anymore, probably quite a bit of gem_prelude could now be removed as well.</p>
<p>Thanks much.<br>
-r<br>
=end</p> Ruby master - Bug #3462: gem activation fails for native gemshttps://bugs.ruby-lang.org/issues/3462?journal_id=125912010-07-30T01:18:30Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>=begin<br>
I've backported r28693, r28695 and r28703. Please check ruby_1_9_2.</p>
<p>We'll release RC3 within a few days (or weeks), and then 1.9.2-p0.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>