Backport #3630: File.expand_path doesn't expand content of HOME env. variable

• Status: Closed
• Assignee: yugui (Yuki Sonoda)

[tmat (Tomas Matousek)]

=begin
Dir.chdir 'C:/temp' do
p File.expand_path("a")

ENV["HOME"] = './abc/../xxx'
p File.expand_path("~/a")

ENV["HOME"] = '/xxx'
p File.expand_path("/a")
end

Prints:

"C:/temp/a"
"./abc/../xxx/a"
"~/xxx/a"

I'd expect it to print:
"C:/temp/a"
"C:/temp/xxx/a"
"C:/temp/~/xxx/a"

The content of HOME variable should be subject to expansion. If it starts with ~/ the tilde should be treated like a regular directory name to avoid recursion.
=end

[luislavena (Luis Lavena)]

=begin
I have one question for you:

File.expand_path('') is supposed to expand to HOME. now, if home contains '', that is supposed to expand to what?

Recursive expansion sounds bad in that context.
=end

[tmat (Tomas Matousek)]

=begin
No it is not suppose to expand tilde again. Only relative paths and .. so that the result of expand_path is a normalized absolute path.
=end

[tmat (Tomas Matousek)]

=begin
That is

Dir.chdir 'c:/temp' do
ENV["HOME"] = ''
File.expand_path('').should == 'c:/temp/~'
end
=end

[nobu (Nobuyoshi Nakada)]

• Category set to core
• Status changed from Open to Closed

=begin
Fixed at r28796.

BTW, please avoid filing Bug issues to 1.9.1, unless it is particular to 1.9.1.
In general, 1.9.1 should accept Backport issues only.

=end

[nobu (Nobuyoshi Nakada)]

• Category set to core
• Assignee set to yugui (Yuki Sonoda)
• Priority changed from Normal to 3

=begin

=end

[mame (Yusuke Endoh)]

• Status changed from Closed to Assigned

=begin

=end

[naruse (Yui NARUSE)]

• Status changed from Assigned to Closed