https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17097754782010-08-01T07:34:32ZRuby Issue Tracking SystemRuby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=126282010-08-01T07:34:32Zluislavena (Luis Lavena)luislavena@gmail.com
<ul></ul><p>=begin<br>
Forgot to mention that with NONAMELESSUNION defined produces the following error:</p>
<p><a href="http://gist.github.com/499840" class="external">http://gist.github.com/499840</a></p>
<p>ext/win32ole/win32ole.c: In function ‘ole_const_load’:<br>
ext/win32ole/win32ole.c:2504:39: error: ‘VARDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c: In function ‘ole_usertype2val’:<br>
ext/win32ole/win32ole.c:4541:44: error: ‘TYPEDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c: In function ‘ole_ptrtype2val’:<br>
ext/win32ole/win32ole.c:4564:13: error: ‘TYPEDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c: In function ‘ole_variable_value’:<br>
ext/win32ole/win32ole.c:6297:31: error: ‘VARDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c: In function ‘ole_param_flag_mask’:<br>
ext/win32ole/win32ole.c:7373:9: error: ‘ELEMDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c: In function ‘ole_param_default’:<br>
ext/win32ole/win32ole.c:7475:19: error: ‘ELEMDESC’ has no member named ‘u’<br>
ext/win32ole/win32ole.c:7477:25: error: ‘ELEMDESC’ has no member named ‘u’</p>
<p>Since *DESC structures do not define the union in any way.<br>
=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=126622010-08-02T21:27:06Zsuke (Masaki Suketa)masaki.suketa@nifty.ne.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
This issue was solved with changeset r28835.<br>
Luis, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<p>=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=126632010-08-03T03:24:18Zluislavena (Luis Lavena)luislavena@gmail.com
<ul></ul><p>=begin<br>
Can this be backported to ruby_1_9_2 too? Thank you.<br>
=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=127042010-08-06T19:44:14Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Open</i></li></ul><p>=begin<br>
Hi,</p>
<p>I was going to backport r28835, but I'm now afraid if it looks like<br>
slightly wrong.</p>
<p>#if (defined(<strong>GNUC</strong>)) && (<strong>GNUC</strong> <= 3) && (<strong>GNUC_MINOR</strong> <= 4) && (<strong>GNUC_PATCHLEVEL</strong> <= 4)</p>
<p>This condition will be false when GCC version is 2.95.3, 3.3.5 or<br>
3.3.6. Is it ok?</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=127062010-08-06T23:42:19Zluislavena (Luis Lavena)luislavena@gmail.com
<ul></ul><p>=begin<br>
Hello Yusuke,</p>
<p>Indeed, my patch was more naive and just removed /mingw/ from the extension compilation process mainly since oldest MinGW available is 3.4.5.</p>
<p>Masaki committed this change. The inverse logic will not work with 4.5.0, 4.5.1 or 4.6.0.</p>
<p>=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=127102010-08-07T09:58:05Zakr (Akira Tanaka)akr@fsij.org
<ul></ul><p>=begin<br>
2010/8/6 Yusuke Endoh <a href="mailto:redmine@ruby-lang.org" class="email">redmine@ruby-lang.org</a>:</p>
<blockquote>
<p>I was going to backport r28835, but I'm now afraid if it looks like<br>
slightly wrong.</p>
<p>#if (defined(<strong>GNUC</strong>)) && (<strong>GNUC</strong> <= 3) && (<strong>GNUC_MINOR</strong> <= 4) && (<strong>GNUC_PATCHLEVEL</strong> <= 4)</p>
<p>This condition will be false when GCC version is 2.95.3, 3.3.5 or<br>
3.3.6. Is it ok?</p>
</blockquote>
<a name="I-recommend-something-like-the-macro-GCC_VERSION_SINCE-in-packc"></a>
<h2 >I recommend something like the macro GCC_VERSION_SINCE in pack.c.<a href="#I-recommend-something-like-the-macro-GCC_VERSION_SINCE-in-packc" class="wiki-anchor">¶</a></h2>
<p>Tanaka Akira</p>
<p>=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=127112010-08-07T10:19:56Zsuke (Masaki Suketa)masaki.suketa@nifty.ne.jp
<ul></ul><p>=begin<br>
Hello,</p>
<p>On Fri, Aug 06, 2010 at 11:42:19PM +0900, Luis Lavena wrote:</p>
<blockquote>
<p>Indeed, my patch was more naive and just removed /mingw/ from the extension compilation process mainly since oldest MinGW available is 3.4.5.</p>
<p>Masaki committed this change. The inverse logic will not work with 4.5.0, 4.5.1 or 4.6.0.</p>
</blockquote>
<p>Sorry, I re-committed the version check logic of gcc.<br>
(trunk revision 28894)</p>
<p>I tested mingw gcc 3.4.5 and cygwin gcc 3.4.4 and cygwin gcc 4.3.4.</p>
<p>Regards,<br>
Masaki Suketa</p>
<p>=end</p> Ruby master - Bug #3637: win32ole: Remove definition of NONAMELESSUNION in MinGWhttps://bugs.ruby-lang.org/issues/3637?journal_id=130402010-08-27T13:45:06Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>=begin</p>
<p>=end</p>